Skip to content

Commit

Permalink
failover: change mtu has RTNL
Browse files Browse the repository at this point in the history
When changing MTU, RTNL is held so use rtnl_dereference
instead of rcu_dereference.

Signed-off-by: Stephen Hemminger <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
shemminger authored and davem330 committed Jul 29, 2018
1 parent 4b09384 commit 3260155
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/net_failover.c
Original file line number Diff line number Diff line change
Expand Up @@ -220,14 +220,14 @@ static int net_failover_change_mtu(struct net_device *dev, int new_mtu)
struct net_device *primary_dev, *standby_dev;
int ret = 0;

primary_dev = rcu_dereference(nfo_info->primary_dev);
primary_dev = rtnl_dereference(nfo_info->primary_dev);
if (primary_dev) {
ret = dev_set_mtu(primary_dev, new_mtu);
if (ret)
return ret;
}

standby_dev = rcu_dereference(nfo_info->standby_dev);
standby_dev = rtnl_dereference(nfo_info->standby_dev);
if (standby_dev) {
ret = dev_set_mtu(standby_dev, new_mtu);
if (ret) {
Expand Down

0 comments on commit 3260155

Please sign in to comment.