Skip to content

Commit

Permalink
Add test case for temporary directories on darwin
Browse files Browse the repository at this point in the history
A test case for correct handling of temporary directory deletion that
was added to check.sh as part of PR NixOS#2689 was initially disabled for
Darwin because of a directory permission issue in PR NixOS#2688.

Now that the issue in PR NixOS#2688 is fixed, this commit enables the test
case for Darwin.
  • Loading branch information
tollb committed Apr 10, 2020
1 parent 8132d0a commit e8bd1bc
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions tests/check.sh
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,8 @@ checkBuildTempDirRemoved $TEST_ROOT/log

nix-build check.nix -A nondeterministic --argstr checkBuildId $checkBuildId \
--no-out-link --check --keep-failed 2> $TEST_ROOT/log || status=$?

# The above nix-build fails with status=1 on darwin (not sure why)
# ...but the primary purpose of the test case is to verify the temp directory is retained
if [ "$(uname -s)" != "Darwin" ]; then
grep 'may not be deterministic' $TEST_ROOT/log
[ "$status" = "104" ]
fi
if checkBuildTempDirRemoved $TEST_ROOT/log; then false; fi

clearStore
Expand Down

0 comments on commit e8bd1bc

Please sign in to comment.