Whitespace clean up and light refactoring

Conflicts: application/src/org/yaaic/activity/ConversationActivity.java
am0c · Jul 2, 2011 · f7ccd50 · f7ccd50
1 parent 84ade9f
commit f7ccd50
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 14 deletions.
diff --git a/application/res/layout/about.xml b/application/res/layout/about.xml
@@ -70,7 +70,7 @@ along with Yaaic.  If not, see <http://www.gnu.org/licenses/>.
         android:id="@+id/about_irclink"
         android:layout_width="fill_parent"
         android:layout_height="wrap_content"
-        android:text="@string/app_irc"
+		android:text="@string/app_irc"
         android:linksClickable="false"
         android:autoLink="none"
         android:textSize="16sp"

diff --git a/application/res/values/settings.xml b/application/res/values/settings.xml
@@ -54,11 +54,11 @@
     <string name="key_autocap_sentences">autocap_sentences</string>
     <string name="default_autocap_sentences">false</string>
 
-	<string name="key_ime_extract">Large landscape input</string>
+	<string name="key_ime_extract">ime_extract</string>
     <string name="default_ime_extract">true</string>
 
-    <string name="key_fullscreen_conversation">Fullscreen chatting</string>
-    <string name="default_fullscreen_conversation">false</string>
+	<string name="key_fullscreen_conversation">fullscreen_conversations</string>
+	<string name="default_fullscreen_conversation">false</string>
 
     <string name="key_history_size">history_size</string>
     <string name="default_history_size">30</string>

diff --git a/application/res/values/strings.xml b/application/res/values/strings.xml
@@ -220,8 +220,8 @@
     <string name="settings_autocorrect_text_desc">Use dictionary to autocorrect typed text in chat</string>
     <string name="settings_autocap_sentences_title">Auto-capitalize sentences</string>
     <string name="settings_autocap_sentences_desc">Automatically capitalize the first word of sentences</string>
-    <string name="settings_ime_extract_title">Large landscape input</string>
-    <string name="settings_ime_extract_desc">Makes the landscape input field multilined</string>
+    <string name="settings_ime_extract_title">Fullscreen input in landscape</string>
+    <string name="settings_ime_extract_desc">Use fullscreen keyboard when in landscape mode</string>
     <string name="settings_fullscreen_conversation_title">Fullscreen chats</string>
     <string name="settings_fullscreen_conversation_desc">Fullscreen the application when chatting</string>
     <string name="settings_history_size_title">History size</string>

diff --git a/application/src/org/yaaic/activity/AboutActivity.java b/application/src/org/yaaic/activity/AboutActivity.java
@@ -58,9 +58,5 @@ public void onClick(View view) {
                 startActivity(i);
             }
         });
-
     }
-
-
-
 }
diff --git a/application/src/org/yaaic/activity/ConversationActivity.java b/application/src/org/yaaic/activity/ConversationActivity.java
@@ -252,14 +252,14 @@ protected void onCreate(Bundle savedInstanceState)
         if (settings.autoCapSentences()) {
             setInputTypeFlags |= InputType.TYPE_TEXT_FLAG_CAP_SENTENCES;
         }
-        if (isLandscape && settings.imeExtract()) {
+        if (isLandscape && !settings.imeExtract()) {
             /* Replace the Enter key with a smiley instead of Send, to make it
                more difficult to accidentally hit send
                We'd like to do this in portrait too, but wouldn't have a Send
                button in that case */
             setInputTypeFlags |= InputType.TYPE_TEXT_VARIATION_SHORT_MESSAGE;
         } else {
-            input.setImeOptions(input.getImeOptions());
+            input.setImeOptions(input.getImeOptions() | EditorInfo.IME_FLAG_NO_EXTRACT_UI);
         }
         input.setInputType(input.getInputType() | setInputTypeFlags);
 

diff --git a/application/src/org/yaaic/model/Settings.java b/application/src/org/yaaic/model/Settings.java
@@ -284,7 +284,7 @@ public boolean autoCapSentences()
     }
 
     /**
-     * Whether conversations should be viewed in Fullscreen glory
+     * Whether the fullscreen keyboard should be used in landscape mode.
      */
     public boolean imeExtract()
     {
@@ -295,7 +295,7 @@ public boolean imeExtract()
     }
 
     /**
-     * Whether conversations should be viewed in Fullscreen glory
+     * Whether conversations should be viewed in Fullscreen glory.
      */
     public boolean fullscreenConversations()
     {
-Original file line number
+Diff line change
@@ Expand Up / @@ -58,9 +58,5 @@ public void onClick(View view) { @@
                     startActivity(i);
                 }
             });
         }
     }