Added Gecko Id to manifest #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used in Firefox forks and Android.
amitbl
added a commit
that referenced
this pull request
Jan 31, 2019
|
Thank you, I fixed the makefile to support this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Firefox forks rely on strict ID tags since firefox changes them on restart some browsers that focus on security and privacy ex; Icecat and Android still require this to be present and will refuse to install without them present in the manifest. This will force min versioning on updates "strict_min_version". And cause warnings in chrome. That said they both can be fixed using the makefile.
The Firefox official docs regarding this can be found here; Firefox Docs