Skip to content

Commit

Permalink
updated CONTRIBUTING.md
Browse files Browse the repository at this point in the history
- signed-off-by: trimstray <[email protected]>
  • Loading branch information
trimstray committed Jan 3, 2019
1 parent d753b5e commit c867467
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Contributing

If you would like to support this project, you have an interesting idea how to improve the operation of this tool or if you found some errors - do fork this add your fixes and add pull-request of your branch to the **testing branch**.
If you would like to support this project, you have an interesting idea how to improve the operation of this tool or if you found some errors - do fork this add your fixes and add pull-request of your branch to the **master branch**.

## Bash style

Expand All @@ -10,9 +10,7 @@ The following should help:

- [http://wiki.bash-hackers.org/](http://wiki.bash-hackers.org/)
- [https://google.github.io/styleguide/shell.xml](https://google.github.io/styleguide/shell.xml)
- [https://github.com/progrium/bashstyle](https://github.com/progrium/bashstyle)


- [https://github.com/progrium/bashstyle](https://github.com/progrium/bashstyl)
- [http://kvz.io/blog/2013/11/21/bash-best-practices/](http://kvz.io/blog/2013/11/21/bash-best-practices/)

## Shellcheck
Expand All @@ -23,15 +21,15 @@ One of the requirements before approving your changes is to check them with the

Moving forward all commits to this project must include a "signed-off-by" line indicating the name and email address of the contributor signing off on the change. To enable signatures add the following lines to `.git/hooks/prepare-commit-msg` :

``````
```
SOB=$(git var GIT_AUTHOR_IDENT | sed -n 's/^\(.*>\).*$/- signed-off-by: \1/p')
grep -qs "^$SOB" "$1" || echo "$SOB" >> "$1"
``````
```

## Pull requests

When creating pull request, please heed the following:

- Base your code on the latest **testing branch**
- Base your code on the latest **master branch**
- Code review may ensue in order to help shape your proposal
- Explain the problem and your proposed solution

0 comments on commit c867467

Please sign in to comment.