Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated readme file #8

Merged
merged 2 commits into from
Oct 30, 2017
Merged

Updated readme file #8

merged 2 commits into from
Oct 30, 2017

Conversation

ArraysNL
Copy link
Contributor

Added intro of basic docs to the readme file. And added a link where to find more documentation.

Fixes: #7

Added intro of basic docs to the readme file. And added a link where to find more documentation.
README.md Outdated
```

## More documentation
More documentation can be found in the [docs folder](docs/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link to https://amphp.org/beanstalk/ instead of the ./docs directory.

README.md Outdated
@@ -4,10 +4,27 @@
[![CoverageStatus](https://img.shields.io/coveralls/amphp/beanstalk/master.svg?style=flat-square)](https://coveralls.io/github/amphp/beanstalkd?branch=master)
![License](https://img.shields.io/badge/license-MIT-blue.svg?style=flat-square)

`amphp/beanstalk` is a non-blocking BeanstalkD client for [Amp](https://github.com/amphp/amp).
`amphp/beanstalk` is an asynchronous client for [Beanstalk](http://kr.github.io/beanstalkd/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about for Beanstalk based on Amp for PHP?

@kelunik
Copy link
Member

kelunik commented Oct 11, 2017

@ArraysNL You might want to fix your e-mail address in the commit, it doesn't properly link to your GitHub account.

External link to the documentation and better excerpt of Beanstalk in general.
Copy link
Contributor Author

@ArraysNL ArraysNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. I did made the changes, just starting doing pull requests so thanks for the patient 👍

@kelunik kelunik merged commit 165f9c2 into amphp:master Oct 30, 2017
@kelunik
Copy link
Member

kelunik commented Oct 30, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants