-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
explain how to install from composer #9
Conversation
README.md
Outdated
Then from the command line: | ||
```bash | ||
composer install | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
composer require
automatically installed new dependencies. Maybe just change it to the version of https://github.com/amphp/amp#installation with a link to Composer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean replace this scope installation with url https://github.com/amphp/amp#installation ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the same text, but with this package of course. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah i see, oke i can make new pr :)
please cek my last commit |
@jokosu10 Sorry, that's not what I meant. I suggested copying the same format from there, so it's consistent. So something like
(without the |
ahh i see, as on as possible i make new pull request |
I don't think this is really more helpful than the previous content. |
add some sentence, how to install package from composer