Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explain how to install from composer #9

Closed
wants to merge 3 commits into from

Conversation

jokosu10
Copy link

add some sentence, how to install package from composer

README.md Outdated
Then from the command line:
```bash
composer install
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

composer require automatically installed new dependencies. Maybe just change it to the version of https://github.com/amphp/amp#installation with a link to Composer?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean replace this scope installation with url https://github.com/amphp/amp#installation ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the same text, but with this package of course. 👍

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah i see, oke i can make new pr :)

@jokosu10
Copy link
Author

please cek my last commit

@kelunik
Copy link
Member

kelunik commented Oct 11, 2017

@jokosu10 Sorry, that's not what I meant. I suggested copying the same format from there, so it's consistent. So something like

... Sentence about composer and link to it here ...

\```
composer require amphp/beanstalk
\```

(without the \)

@jokosu10
Copy link
Author

ahh i see, as on as possible i make new pull request

@kelunik
Copy link
Member

kelunik commented Oct 30, 2017

I don't think this is really more helpful than the previous content.

@kelunik kelunik closed this Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants