Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Reload page on self redirect if hash is not present in DOM #37920

Closed
wants to merge 4 commits into from
Closed

✨ Reload page on self redirect if hash is not present in DOM #37920

wants to merge 4 commits into from

Conversation

deepaklalwani97
Copy link
Contributor

@deepaklalwani97 deepaklalwani97 commented Mar 21, 2022 •
edited
Loading

Fixes #14170

  • Reload the page via the AMP-Redirect-To header for self-redirect URLs if the element with URL fragment is not present in the DOM.
  • Add unit test cases

@deepaklalwani97 deepaklalwani97 marked this pull request as ready for review March 21, 2022 07:27
@amp-owners-bot amp-owners-bot bot requested a review from rsimha March 21, 2022 07:27
@stale
Copy link

stale bot commented May 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label May 21, 2023
@stale stale bot closed this Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsimha rsimha Awaiting requested review from rsimha

Assignees
No one assigned
Labels
Stale Inactive for one year or more
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to reload (self-redirect) via AMP-Redirect-To when fragment added to current location
2 participants
@deepaklalwani97 @AnuragVasanwala