Apple required update #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Clean up credit dialog - change icon to access about - replace description - replace credits
Still trying to use SwiftRadio. Fixed.
- Added fastlane - added fastlane config for snapshots - Changed UI tests to take appropriate snapshots
- screenshots dir - report.xml in fastlane
Turn tests back on now that they work
- Added labels to stack - added code to set PLAYING LIVE label
- This version hits the /broadcast endpoint and tries to parse the current_show. If there is none, then we assume it's Spud. This avoids the complicated decoding of a dual-typed field (current_show, which is either false or a struct). - Updates the UI to show the current DJ's name.
…igh enough - was >= 180; changed to <= 300
- run on the iPad Pro now seems to work, and the "constraint broken" errors are fixed.
|
Closing this PR as it includes personal project updates not intended for the main project. |
|
Thanks — had my remotes set won’t, sorry.
…On Sat, Jan 13, 2024 at 6:06 PM Fethi El Hassasna ***@***.***> wrote:
Closed #188 <#188>.
—
Reply to this email directly, view it on GitHub
<#188 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAO6GY27ZUH6KLOWAYO5L3YOM4SJAVCNFSM6AAAAAA73ERRVCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGQ3TSNRSGQZDKNQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original RadioSpiral has aged out, and Apple thinks I'm not maintaining it. Catch up with Swift-Radio-Pro for now, and replace with a SwiftUI version ASAP.