#167749962 Implement user can view all own travel requests submitted #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldonjibson
changed the title
ldonjibson
force-pushed
the
ft-all-requests-submited-by-user-167749962
branch
from
12b3c98 to
65610e7
Compare
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
ldonjibson
force-pushed
the
ft-all-requests-submited-by-user-167749962
branch
4 times, most recently
from
2ede01e to
d1c5da9
Compare
ldonjibson
force-pushed
the
ft-all-requests-submited-by-user-167749962
branch
4 times, most recently
from
4bfbd76 to
b7a21f0
Compare
ldonjibson
force-pushed
the
ft-all-requests-submited-by-user-167749962
branch
from
b7a21f0 to
26bbd89
Compare
ldonjibson
force-pushed
the
ft-all-requests-submited-by-user-167749962
branch
from
26bbd89 to
73002de
Compare
ldonjibson
force-pushed
the
ft-all-requests-submited-by-user-167749962
branch
2 times, most recently
from
c302e78 to
815d6eb
Compare
ldonjibson
force-pushed
the
ft-all-requests-submited-by-user-167749962
branch
2 times, most recently
from
f262c40 to
b68a62c
Compare
src/controllers/RequestController.js
Outdated
| } | ||
| Responses.setSuccess(200, 'Trip requests retrieved successfully', userTrips); | ||
| return Responses.send(res); | ||
| }) |
There was a problem hiding this comment.
Kindly add semi colon to line 56
- create new request controller to retrieve all requests of a user - create new service to retrieve the data needed from database after authentication has passed - create route to access and retreive databse response - create test for the endpoint - add endpoint to swagger documentation [Delivers #167749962]
ldonjibson
force-pushed
the
ft-all-requests-submited-by-user-167749962
branch
from
b68a62c to
3d1712e
Compare
alatos2
approved these changes
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR implements user can view all own travel requests submitted
Description of Tasks to be completed
authentication has passed
How should this be manually tested?
Relevant pivotal tracker story
#167749962