Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature] Timeout-capable channels #51

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

[New Feature] Timeout-capable channels #51

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9b32652
Implemented API-compatible throwing timeout functionality
dario-loi Jan 8, 2025
c149418
README.md updated
dario-loi Jan 8, 2025
1f89d8d
Atomic timeout variable for lock-free setting
dario-loi Jan 8, 2025
892ba14
basic test suite for timeout feature
dario-loi Jan 8, 2025
3a82b34
Removed C++20 attributes
dario-loi Jan 8, 2025
aedccfa
Atomic pre-loading and relaxed ordering
dario-loi Jan 8, 2025
76775cb
CI/CD bump to GCC12
dario-loi Jan 9, 2025
cdf5c50
Perfect forwarding
dario-loi Jan 16, 2025
af2b030
Resolved issues not related to refactoring
dario-loi Jan 16, 2025
949aca1
Fixed universal reference changes not being consistent
dario-loi Jan 16, 2025
9811914
Remove impl from channel.hpp
dario-loi Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CI/CD bump to GCC12
  • Loading branch information
@dario-loi
dario-loi committed Jan 9, 2025
commit 76775cb7a1d0dad4e32a5a8b741811af953172c9
10 changes: 10 additions & 0 deletions .github/workflows/cmake.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,16 @@ jobs:

steps:
- uses: actions/checkout@v4

- name: Install GCC 12
if: runner.os == 'Linux'
run: |
sudo apt-get update
sudo apt-get install -y gcc-12 g++-12 cmake
Comment on lines +53 to +54
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"gcc-12 is already the newest version (12.3.0-1ubuntu1~22.04)."

Is update-alternatives enough?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By removing the apt-get call I get:

| update-alternatives: error: alternative path /usr/bin/gcc-12 doesn't exist
[build/Ubuntu 22.04 GCC (Debug)-2    ]   ❌  Failure - Main Install GCC 12

I am honestly not familiar with Ubuntu so maybe I am not doing this correctly.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you tried this locally, maybe you don't have GCC 12 already installed. On the GitHub runner, I see 12 is already installed, but not used as default. So just try it here without apt-get update and install.

sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-12 100
sudo update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-12 100
gcc --version
g++ --version

- name: Create Build Environment
# Some projects don't allow in-source building, so create a separate build directory
Expand Down
Loading