Tags: andrey-borue/tyk
Tags
Merging to release-5.7.0: Revert "[TT-13422] Do not allow empty strin… …g in upstream auth configuration strings" (TykTechnologies#6702) (TykTechnologies#6704) ### **User description** Revert "[TT-13422] Do not allow empty string in upstream auth configuration strings" (TykTechnologies#6702) Reverts TykTechnologies#6699 temporary revert with common change for AuthSource [TT-13422]: https://tyktech.atlassian.net/browse/TT-13422?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ ___ ### **PR Type** enhancement, bug fix ___ ### **Description** - Reverted changes that enforced non-empty strings in the OpenAPI Specification (OAS) schema, specifically for the `name` property in `X-Tyk-AuthSource`. - Adjusted references for `header` properties in various authentication objects to use `X-Tyk-UpstreamAuthSource`. - Reintroduced the `X-Tyk-UpstreamAuthSource` definition to align with previous configurations. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>x-tyk-api-gateway.json</strong><dd><code>Revert non-empty string enforcement and adjust AuthSource references</code></dd></summary> <hr> apidef/oas/schema/x-tyk-api-gateway.json <li>Reverted the <code>name</code> property in <code>X-Tyk-AuthSource</code> to use <code>type: string</code> <br>instead of <code>X-Tyk-NonEmptyString</code>.<br> <li> Changed <code>$ref</code> for <code>header</code> in <code>X-Tyk-UpstreamBasicAuthentication</code> and other <br>sections to <code>X-Tyk-UpstreamAuthSource</code>.<br> <li> Reintroduced <code>X-Tyk-UpstreamAuthSource</code> definition with <code>name</code> as a string <br>type.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6704/files#diff-78828969c0c04cc1a776dfc93a8bad3c499a8c83e6169f83e96d090bed3e7dd0">+15/-4</a> </td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull request to receive relevant information Co-authored-by: Jeffy Mathew <[email protected]>
[TT-13508] Downgrade Bento to v1.2.0 and use our own fork to cherry-p… …ick some changes from latest main branch. (TykTechnologies#6700) ### **User description** Bento >=1.3.0 requires an OpenTelemetry upgrade and it breaks our E2E tests. Here is some details: https://tyktech.atlassian.net/browse/TT-13518 This PR downgrades Bento to v1.2.0 and cherry-picks some changes from the main branch to fix TT-13508. See this TykTechnologies#6697 ___ ### **PR Type** enhancement, dependencies ___ ### **Description** - Downgraded `google.golang.org/grpc` from v1.67.0 to v1.66.2 to address compatibility issues. - Downgraded `github.com/warpstreamlabs/bento` from v1.3.1 to v1.2.0 and replaced it with a forked version from `github.com/TykTechnologies/bento`. - Downgraded `go.opentelemetry.io/otel` and related packages from v1.29.0 to v1.24.0 to resolve issues with OpenTelemetry upgrades. - Updated multiple indirect dependencies to earlier versions to maintain compatibility and stability. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Dependencies</strong></td><td><table> <tr> <td> <details> <summary><strong>go.mod</strong><dd><code>Downgrade dependencies and switch to a forked Bento version</code></dd></summary> <hr> go.mod <li>Downgraded <code>google.golang.org/grpc</code> from v1.67.0 to v1.66.2.<br> <li> Downgraded <code>github.com/warpstreamlabs/bento</code> from v1.3.1 to v1.2.0 and <br>replaced it with a fork.<br> <li> Downgraded <code>go.opentelemetry.io/otel</code> and related packages from v1.29.0 <br>to v1.24.0.<br> <li> Updated multiple indirect dependencies to earlier versions.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6700/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6">+47/-65</a> </td> </tr> </table></td></tr><tr><td><strong>Additional files (token-limit)</strong></td><td><table> <tr> <td> <details> <summary><strong>go.sum</strong><dd><code>...</code> </dd></summary> <hr> go.sum ... </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6700/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63">+103/-1054</a></td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull request to receive relevant information
Merging to release-5.3.8: Tt 13476 update gw oas version (TykTechnolo… …gies#6692) Tt 13476 update gw oas version (TykTechnologies#6692) https://github.com/TykTechnologies/tyk-analytics/pull/4281/files ## Description Updates gateway OpenAPI version ## Related Issue <!-- This project only accepts pull requests related to open issues. --> <!-- If suggesting a new feature or change, please discuss it in an issue first. --> <!-- If fixing a bug, there should be an issue describing it with steps to reproduce. --> <!-- OSS: Please link to the issue here. Tyk: please create/link the JIRA ticket. --> ## Motivation and Context <!-- Why is this change required? What problem does it solve? --> ## How This Has Been Tested <!-- Please describe in detail how you tested your changes --> <!-- Include details of your testing environment, and the tests --> <!-- you ran to see how your change affects other areas of the code, etc. --> <!-- This information is helpful for reviewers and QA. --> ## Screenshots (if appropriate) ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply --> <!-- If there are no documentation updates required, mark the item as checked. --> <!-- Raise up any additional concerns not covered by the checklist. --> - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why
[TT-11426/TT-13322]add deprecation notice for oidc middleware (TykTec… …hnologies#6686) ### **User description** <details open> <summary><a href="https://tyktech.atlassian.net/browse/TT-13322" title="TT-13322" target="_blank">TT-13322</a></summary> <br /> <table> <tr> <th>Summary</th> <td>Add warning message in GW logs, schema and go docs</td> </tr> <tr> <th>Type</th> <td> <img alt="Sub-task" src="https://tyktech.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10316?size=medium" /> Sub-task </td> </tr> <tr> <th>Status</th> <td>In Dev</td> </tr> <tr> <th>Points</th> <td>N/A</td> </tr> <tr> <th>Labels</th> <td><a href="https://tyktech.atlassian.net/issues?jql=project%20%3D%20TT%20AND%20labels%20%3D%20QA_Fail%20ORDER%20BY%20created%20DESC" title="QA_Fail">QA_Fail</a></td> </tr> </table> </details> <!-- do not remove this marker as it will break jira-lint's functionality. added_by_jira_lint --> --- <!-- Provide a general summary of your changes in the Title above --> ## Description <!-- Describe your changes in detail --> ## Related Issue Parent: https://tyktech.atlassian.net/browse/TT-11426 Subtask: https://tyktech.atlassian.net/browse/TT-13322 ## Motivation and Context <!-- Why is this change required? What problem does it solve? --> ## How This Has Been Tested <!-- Please describe in detail how you tested your changes --> <!-- Include details of your testing environment, and the tests --> <!-- you ran to see how your change affects other areas of the code, etc. --> <!-- This information is helpful for reviewers and QA. --> ## Screenshots (if appropriate) ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply --> <!-- If there are no documentation updates required, mark the item as checked. --> <!-- Raise up any additional concerns not covered by the checklist. --> - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why ___ ### **PR Type** documentation, enhancement ___ ### **Description** - Added deprecation notices for OpenID Connect middleware and OIDC authentication mode in code comments and documentation. - Introduced log warnings in the OpenID middleware to inform users of the deprecation. - Recommended using JSON Web Token (JWT) as an alternative to avoid disruptions. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Documentation</strong></td><td><table> <tr> <td> <details> <summary><strong>api_definitions.go</strong><dd><code>Add deprecation notice for OpenID Connect middleware</code> </dd></summary> <hr> apidef/api_definitions.go <li>Added deprecation notice for OpenID Connect middleware.<br> <li> Recommended using JSON Web Token (JWT) instead.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6686/files#diff-9961ccc89a48d32db5b47ba3006315ef52f6e5007fb4b09f8c5d6d299c669d67">+3/-0</a> </td> </tr> <tr> <td> <details> <summary><strong>authentication.go</strong><dd><code>Add deprecation notice for OIDC authentication mode</code> </dd></summary> <hr> apidef/oas/authentication.go <li>Added deprecation notice for OIDC authentication mode.<br> <li> Recommended using JSON Web Token (JWT) instead.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6686/files#diff-e51c9d24d4235e7cc53048cc1d92967d177585ba5e073f14876308a97bef6326">+3/-0</a> </td> </tr> <tr> <td> <details> <summary><strong>x-tyk-api-gateway.json</strong><dd><code>Add deprecation notice for external OAuth Middleware</code> </dd></summary> <hr> apidef/oas/schema/x-tyk-api-gateway.json <li>Added deprecation notice for external OAuth Middleware.<br> <li> Recommended using JSON Web Token (JWT) instead.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6686/files#diff-78828969c0c04cc1a776dfc93a8bad3c499a8c83e6169f83e96d090bed3e7dd0">+1/-0</a> </td> </tr> </table></td></tr><tr><td><strong>Enhancement</strong></td><td><table> <tr> <td> <details> <summary><strong>mw_openid.go</strong><dd><code>Add log warning for deprecated OpenID Connect Middleware</code> </dd></summary> <hr> gateway/mw_openid.go <li>Added log warning for deprecated OpenID Connect Middleware.<br> <li> Recommended using JSON Web Token (JWT) instead.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6686/files#diff-a389c2a490b728d3bf6ed64f974b227117fb451aa2da8ce8df8c859e7cdc718a">+4/-0</a> </td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull request to receive relevant information
Merging to release-5.3: [TT-11426/TT-13322]add deprecation notice for… … oidc middleware (TykTechnologies#6686) [TT-11426/TT-13322]add deprecation notice for oidc middleware (TykTechnologies#6686) ### **User description** <details open> <summary><a href="https://tyktech.atlassian.net/browse/TT-13322" title="TT-13322" target="_blank">TT-13322</a></summary> <br /> <table> <tr> <th>Summary</th> <td>Add warning message in GW logs, schema and go docs</td> </tr> <tr> <th>Type</th> <td> <img alt="Sub-task" src="https://tyktech.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10316?size=medium" /> Sub-task </td> </tr> <tr> <th>Status</th> <td>In Dev</td> </tr> <tr> <th>Points</th> <td>N/A</td> </tr> <tr> <th>Labels</th> <td><a href="https://tyktech.atlassian.net/issues?jql=project%20%3D%20TT%20AND%20labels%20%3D%20QA_Fail%20ORDER%20BY%20created%20DESC" title="QA_Fail">QA_Fail</a></td> </tr> </table> </details> <!-- do not remove this marker as it will break jira-lint's functionality. added_by_jira_lint --> --- <!-- Provide a general summary of your changes in the Title above --> ## Description <!-- Describe your changes in detail --> ## Related Issue Parent: https://tyktech.atlassian.net/browse/TT-11426 Subtask: https://tyktech.atlassian.net/browse/TT-13322 ## Motivation and Context <!-- Why is this change required? What problem does it solve? --> ## How This Has Been Tested <!-- Please describe in detail how you tested your changes --> <!-- Include details of your testing environment, and the tests --> <!-- you ran to see how your change affects other areas of the code, etc. --> <!-- This information is helpful for reviewers and QA. --> ## Screenshots (if appropriate) ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply --> <!-- If there are no documentation updates required, mark the item as checked. --> <!-- Raise up any additional concerns not covered by the checklist. --> - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why ___ ### **PR Type** documentation, enhancement ___ ### **Description** - Added deprecation notices for OpenID Connect middleware and OIDC authentication mode in code comments and documentation. - Introduced log warnings in the OpenID middleware to inform users of the deprecation. - Recommended using JSON Web Token (JWT) as an alternative to avoid disruptions. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Documentation</strong></td><td><table> <tr> <td> <details> <summary><strong>api_definitions.go</strong><dd><code>Add deprecation notice for OpenID Connect middleware</code> </dd></summary> <hr> apidef/api_definitions.go <li>Added deprecation notice for OpenID Connect middleware.<br> <li> Recommended using JSON Web Token (JWT) instead.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6686/files#diff-9961ccc89a48d32db5b47ba3006315ef52f6e5007fb4b09f8c5d6d299c669d67">+3/-0</a> </td> </tr> <tr> <td> <details> <summary><strong>authentication.go</strong><dd><code>Add deprecation notice for OIDC authentication mode</code> </dd></summary> <hr> apidef/oas/authentication.go <li>Added deprecation notice for OIDC authentication mode.<br> <li> Recommended using JSON Web Token (JWT) instead.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6686/files#diff-e51c9d24d4235e7cc53048cc1d92967d177585ba5e073f14876308a97bef6326">+3/-0</a> </td> </tr> <tr> <td> <details> <summary><strong>x-tyk-api-gateway.json</strong><dd><code>Add deprecation notice for external OAuth Middleware</code> </dd></summary> <hr> apidef/oas/schema/x-tyk-api-gateway.json <li>Added deprecation notice for external OAuth Middleware.<br> <li> Recommended using JSON Web Token (JWT) instead.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6686/files#diff-78828969c0c04cc1a776dfc93a8bad3c499a8c83e6169f83e96d090bed3e7dd0">+1/-0</a> </td> </tr> </table></td></tr><tr><td><strong>Enhancement</strong></td><td><table> <tr> <td> <details> <summary><strong>mw_openid.go</strong><dd><code>Add log warning for deprecated OpenID Connect Middleware</code> </dd></summary> <hr> gateway/mw_openid.go <li>Added log warning for deprecated OpenID Connect Middleware.<br> <li> Recommended using JSON Web Token (JWT) instead.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6686/files#diff-a389c2a490b728d3bf6ed64f974b227117fb451aa2da8ce8df8c859e7cdc718a">+4/-0</a> </td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull request to receive relevant information
Merging to release-5.3: [TT-11426/TT-13322]add deprecation notice for… … oidc middleware (TykTechnologies#6686) [TT-11426/TT-13322]add deprecation notice for oidc middleware (TykTechnologies#6686) ### **User description** <details open> <summary><a href="https://tyktech.atlassian.net/browse/TT-13322" title="TT-13322" target="_blank">TT-13322</a></summary> <br /> <table> <tr> <th>Summary</th> <td>Add warning message in GW logs, schema and go docs</td> </tr> <tr> <th>Type</th> <td> <img alt="Sub-task" src="https://tyktech.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10316?size=medium" /> Sub-task </td> </tr> <tr> <th>Status</th> <td>In Dev</td> </tr> <tr> <th>Points</th> <td>N/A</td> </tr> <tr> <th>Labels</th> <td><a href="https://tyktech.atlassian.net/issues?jql=project%20%3D%20TT%20AND%20labels%20%3D%20QA_Fail%20ORDER%20BY%20created%20DESC" title="QA_Fail">QA_Fail</a></td> </tr> </table> </details> <!-- do not remove this marker as it will break jira-lint's functionality. added_by_jira_lint --> --- <!-- Provide a general summary of your changes in the Title above --> ## Description <!-- Describe your changes in detail --> ## Related Issue Parent: https://tyktech.atlassian.net/browse/TT-11426 Subtask: https://tyktech.atlassian.net/browse/TT-13322 ## Motivation and Context <!-- Why is this change required? What problem does it solve? --> ## How This Has Been Tested <!-- Please describe in detail how you tested your changes --> <!-- Include details of your testing environment, and the tests --> <!-- you ran to see how your change affects other areas of the code, etc. --> <!-- This information is helpful for reviewers and QA. --> ## Screenshots (if appropriate) ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply --> <!-- If there are no documentation updates required, mark the item as checked. --> <!-- Raise up any additional concerns not covered by the checklist. --> - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why ___ ### **PR Type** documentation, enhancement ___ ### **Description** - Added deprecation notices for OpenID Connect middleware and OIDC authentication mode in code comments and documentation. - Introduced log warnings in the OpenID middleware to inform users of the deprecation. - Recommended using JSON Web Token (JWT) as an alternative to avoid disruptions. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Documentation</strong></td><td><table> <tr> <td> <details> <summary><strong>api_definitions.go</strong><dd><code>Add deprecation notice for OpenID Connect middleware</code> </dd></summary> <hr> apidef/api_definitions.go <li>Added deprecation notice for OpenID Connect middleware.<br> <li> Recommended using JSON Web Token (JWT) instead.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6686/files#diff-9961ccc89a48d32db5b47ba3006315ef52f6e5007fb4b09f8c5d6d299c669d67">+3/-0</a> </td> </tr> <tr> <td> <details> <summary><strong>authentication.go</strong><dd><code>Add deprecation notice for OIDC authentication mode</code> </dd></summary> <hr> apidef/oas/authentication.go <li>Added deprecation notice for OIDC authentication mode.<br> <li> Recommended using JSON Web Token (JWT) instead.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6686/files#diff-e51c9d24d4235e7cc53048cc1d92967d177585ba5e073f14876308a97bef6326">+3/-0</a> </td> </tr> <tr> <td> <details> <summary><strong>x-tyk-api-gateway.json</strong><dd><code>Add deprecation notice for external OAuth Middleware</code> </dd></summary> <hr> apidef/oas/schema/x-tyk-api-gateway.json <li>Added deprecation notice for external OAuth Middleware.<br> <li> Recommended using JSON Web Token (JWT) instead.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6686/files#diff-78828969c0c04cc1a776dfc93a8bad3c499a8c83e6169f83e96d090bed3e7dd0">+1/-0</a> </td> </tr> </table></td></tr><tr><td><strong>Enhancement</strong></td><td><table> <tr> <td> <details> <summary><strong>mw_openid.go</strong><dd><code>Add log warning for deprecated OpenID Connect Middleware</code> </dd></summary> <hr> gateway/mw_openid.go <li>Added log warning for deprecated OpenID Connect Middleware.<br> <li> Recommended using JSON Web Token (JWT) instead.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6686/files#diff-a389c2a490b728d3bf6ed64f974b227117fb451aa2da8ce8df8c859e7cdc718a">+4/-0</a> </td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull request to receive relevant information
Merging to release-5.3: [TT-11426/TT-13322]add deprecation notice for… … oidc middleware (TykTechnologies#6686) [TT-11426/TT-13322]add deprecation notice for oidc middleware (TykTechnologies#6686) ### **User description** <details open> <summary><a href="https://tyktech.atlassian.net/browse/TT-13322" title="TT-13322" target="_blank">TT-13322</a></summary> <br /> <table> <tr> <th>Summary</th> <td>Add warning message in GW logs, schema and go docs</td> </tr> <tr> <th>Type</th> <td> <img alt="Sub-task" src="https://tyktech.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10316?size=medium" /> Sub-task </td> </tr> <tr> <th>Status</th> <td>In Dev</td> </tr> <tr> <th>Points</th> <td>N/A</td> </tr> <tr> <th>Labels</th> <td><a href="https://tyktech.atlassian.net/issues?jql=project%20%3D%20TT%20AND%20labels%20%3D%20QA_Fail%20ORDER%20BY%20created%20DESC" title="QA_Fail">QA_Fail</a></td> </tr> </table> </details> <!-- do not remove this marker as it will break jira-lint's functionality. added_by_jira_lint --> --- <!-- Provide a general summary of your changes in the Title above --> ## Description <!-- Describe your changes in detail --> ## Related Issue Parent: https://tyktech.atlassian.net/browse/TT-11426 Subtask: https://tyktech.atlassian.net/browse/TT-13322 ## Motivation and Context <!-- Why is this change required? What problem does it solve? --> ## How This Has Been Tested <!-- Please describe in detail how you tested your changes --> <!-- Include details of your testing environment, and the tests --> <!-- you ran to see how your change affects other areas of the code, etc. --> <!-- This information is helpful for reviewers and QA. --> ## Screenshots (if appropriate) ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply --> <!-- If there are no documentation updates required, mark the item as checked. --> <!-- Raise up any additional concerns not covered by the checklist. --> - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why ___ ### **PR Type** documentation, enhancement ___ ### **Description** - Added deprecation notices for OpenID Connect middleware and OIDC authentication mode in code comments and documentation. - Introduced log warnings in the OpenID middleware to inform users of the deprecation. - Recommended using JSON Web Token (JWT) as an alternative to avoid disruptions. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Documentation</strong></td><td><table> <tr> <td> <details> <summary><strong>api_definitions.go</strong><dd><code>Add deprecation notice for OpenID Connect middleware</code> </dd></summary> <hr> apidef/api_definitions.go <li>Added deprecation notice for OpenID Connect middleware.<br> <li> Recommended using JSON Web Token (JWT) instead.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6686/files#diff-9961ccc89a48d32db5b47ba3006315ef52f6e5007fb4b09f8c5d6d299c669d67">+3/-0</a> </td> </tr> <tr> <td> <details> <summary><strong>authentication.go</strong><dd><code>Add deprecation notice for OIDC authentication mode</code> </dd></summary> <hr> apidef/oas/authentication.go <li>Added deprecation notice for OIDC authentication mode.<br> <li> Recommended using JSON Web Token (JWT) instead.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6686/files#diff-e51c9d24d4235e7cc53048cc1d92967d177585ba5e073f14876308a97bef6326">+3/-0</a> </td> </tr> <tr> <td> <details> <summary><strong>x-tyk-api-gateway.json</strong><dd><code>Add deprecation notice for external OAuth Middleware</code> </dd></summary> <hr> apidef/oas/schema/x-tyk-api-gateway.json <li>Added deprecation notice for external OAuth Middleware.<br> <li> Recommended using JSON Web Token (JWT) instead.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6686/files#diff-78828969c0c04cc1a776dfc93a8bad3c499a8c83e6169f83e96d090bed3e7dd0">+1/-0</a> </td> </tr> </table></td></tr><tr><td><strong>Enhancement</strong></td><td><table> <tr> <td> <details> <summary><strong>mw_openid.go</strong><dd><code>Add log warning for deprecated OpenID Connect Middleware</code> </dd></summary> <hr> gateway/mw_openid.go <li>Added log warning for deprecated OpenID Connect Middleware.<br> <li> Recommended using JSON Web Token (JWT) instead.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6686/files#diff-a389c2a490b728d3bf6ed64f974b227117fb451aa2da8ce8df8c859e7cdc718a">+4/-0</a> </td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull request to receive relevant information
[TT-12417] Do not delete keys on synchronization (TykTechnologies#6642) <details open> <summary><a href="https://tyktech.atlassian.net/browse/TT-12417" title="TT-12417" target="_blank">TT-12417</a></summary> <br /> <table> <tr> <th>Summary</th> <td>Api keys are lost in worker gateways when keyspace sync interrupted</td> </tr> <tr> <th>Type</th> <td> <img alt="Bug" src="https://tyktech.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10303?size=medium" /> Bug </td> </tr> <tr> <th>Status</th> <td>In Dev</td> </tr> <tr> <th>Points</th> <td>N/A</td> </tr> <tr> <th>Labels</th> <td><a href="https://tyktech.atlassian.net/issues?jql=project%20%3D%20TT%20AND%20labels%20%3D%20customer_bug%20ORDER%20BY%20created%20DESC" title="customer_bug">customer_bug</a>, <a href="https://tyktech.atlassian.net/issues?jql=project%20%3D%20TT%20AND%20labels%20%3D%20jira_escalated%20ORDER%20BY%20created%20DESC" title="jira_escalated">jira_escalated</a></td> </tr> </table> </details> <!-- do not remove this marker as it will break jira-lint's functionality. added_by_jira_lint --> --- <!-- Provide a general summary of your changes in the Title above --> ## Description Avoiding key deletion when synchronizing. This will avoid having inconsistent key data between master and slave Redis. <!-- Describe your changes in detail --> ## Related Issue https://tyktech.atlassian.net/browse/TT-12417?atlOrigin=eyJpIjoiYWNiZTdlNmYwODY5NDI1ZDkzYmQ1MWFlZjM5NGQ3ZTgiLCJwIjoiaiJ9 <!-- This project only accepts pull requests related to open issues. --> <!-- If suggesting a new feature or change, please discuss it in an issue first. --> <!-- If fixing a bug, there should be an issue describing it with steps to reproduce. --> <!-- OSS: Please link to the issue here. Tyk: please create/link the JIRA ticket. --> ## Motivation and Context https://tyktech.atlassian.net/browse/TT-12417?atlOrigin=eyJpIjoiYWNiZTdlNmYwODY5NDI1ZDkzYmQ1MWFlZjM5NGQ3ZTgiLCJwIjoiaiJ9 <!-- Why is this change required? What problem does it solve? --> ## How This Has Been Tested <!-- Please describe in detail how you tested your changes --> <!-- Include details of your testing environment, and the tests --> <!-- you ran to see how your change affects other areas of the code, etc. --> <!-- This information is helpful for reviewers and QA. --> ## Screenshots (if appropriate) ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply --> <!-- If there are no documentation updates required, mark the item as checked. --> <!-- Raise up any additional concerns not covered by the checklist. --> - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why
Merging to release-5.0.15: [TT-13110] remove trimpath from 5-lts build ( TykTechnologies#6546) (TykTechnologies#6666) [TT-13110] remove trimpath from 5-lts build (TykTechnologies#6546) <!-- Provide a general summary of your changes in the Title above --> ## Description Remove `-trimpath` build flag from goreleaser build so that plugins built with tyk plugin compiler loads. ## Related Issue https://tyktech.atlassian.net/browse/TT-13110 ## Motivation and Context <!-- Why is this change required? What problem does it solve? --> ## How This Has Been Tested <!-- Please describe in detail how you tested your changes --> <!-- Include details of your testing environment, and the tests --> <!-- you ran to see how your change affects other areas of the code, etc. --> <!-- This information is helpful for reviewers and QA. --> ## Screenshots (if appropriate) ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply --> <!-- If there are no documentation updates required, mark the item as checked. --> <!-- Raise up any additional concerns not covered by the checklist. --> - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why [TT-13110]: https://tyktech.atlassian.net/browse/TT-13110?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: Jeffy Mathew <[email protected]>
Merging to release-5.0.15: [TT-13110] remove trimpath from 5-lts build ( TykTechnologies#6546) (TykTechnologies#6666) [TT-13110] remove trimpath from 5-lts build (TykTechnologies#6546) <!-- Provide a general summary of your changes in the Title above --> ## Description Remove `-trimpath` build flag from goreleaser build so that plugins built with tyk plugin compiler loads. ## Related Issue https://tyktech.atlassian.net/browse/TT-13110 ## Motivation and Context <!-- Why is this change required? What problem does it solve? --> ## How This Has Been Tested <!-- Please describe in detail how you tested your changes --> <!-- Include details of your testing environment, and the tests --> <!-- you ran to see how your change affects other areas of the code, etc. --> <!-- This information is helpful for reviewers and QA. --> ## Screenshots (if appropriate) ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply --> <!-- If there are no documentation updates required, mark the item as checked. --> <!-- Raise up any additional concerns not covered by the checklist. --> - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why [TT-13110]: https://tyktech.atlassian.net/browse/TT-13110?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: Jeffy Mathew <[email protected]>
PreviousNext