Update build scripts to improve intoto.jsonl file handling #90
Conversation
This commit modifies `build_presubmit.sh` and `build.sh` to: - List found `.intoto.jsonl` files before copying. - Exit with a failure status if no `.intoto.jsonl` files are found. - Exit with a failure status if the AAB file is not found.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @riggaroo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on improving the reliability and clarity of the build process by updating the build.sh and build_presubmit.sh scripts. The changes introduce more stringent error checks for essential build outputs and enhance the logging around .intoto.jsonl file handling, ensuring that the build fails predictably and provides clear feedback when expected files are missing.
Highlights
- Build Script Robustness: Enhanced error handling in both
build.shandbuild_presubmit.shto explicitly fail the build process if the expected AAB (Android App Bundle) file is not found, or if no.intoto.jsonlfiles are present. This ensures that critical build artifacts are accounted for and prevents silent failures. - Intoto File Handling Visibility: Improved the handling of
.intoto.jsonlfiles by modifying the scripts to first list all found.intoto.jsonlfiles before copying them. This provides better transparency and logging, making it easier to verify which files are being processed.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the build scripts to improve handling of .intoto.jsonl files by adding checks for their existence and failing the build if they are not found. The changes are functionally correct and meet the stated goals. The review focuses on improving the efficiency and robustness of the implementation by avoiding redundant find commands and using safer methods for handling file paths.
This commit introduces the SPDX SBOM Gradle plugin to generate a Software Bill of Materials (SBOM) for release builds. The following changes were made: - Added the `org.spdx.sbom` plugin to `app/build.gradle.kts`. - Configured the plugin to generate an SBOM for the `releaseRuntimeClasspath` configuration. - Updated `build.sh` and `build_presubmit.sh` to execute the `app:spdxSbomForRelease` task and copy the generated SBOM to the artifacts directory. - Updated Kokoro configurations (`continuous.cfg`, `presubmit.cfg`, `release.cfg`) to include the `app-release.spdx.json` SBOM file in the build artifacts.
This commit modifies
build_presubmit.shandbuild.shto:.intoto.jsonlfiles before copying..intoto.jsonlfiles are found.