-
Notifications
You must be signed in to change notification settings - Fork 163
Foldable Layout - Sizes #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit makes the following changes: - Makes the AspectRatioTool scrollable vertically. - Changes the BackgroundTool item size to a fixed 70dp, removing the aspect ratio constraint - to fix sizing on foldables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @riggaroo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've made changes to improve the layout and user experience on foldable devices. Specifically, I've enabled vertical scrolling for the AspectRatioTool
to ensure its content is always accessible, and I've adjusted the item sizing in the BackgroundTool
to a fixed dimension, which resolves layout inconsistencies on foldable screens.
Highlights
- AspectRatioTool Scrollability: The
AspectRatioTool
composable has been updated to support vertical scrolling, ensuring its content remains accessible on various screen configurations, especially foldable devices. - BackgroundTool Item Sizing: The
BackgroundTool
now uses a fixed size of70dp
for its items, replacing the previousaspectRatio(1f)
constraint. This change specifically addresses sizing issues on foldable devices, providing a consistent layout.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to improve layout on foldable devices by making the AspectRatioTool
vertically scrollable and fixing the item size in BackgroundTool
. The change in BackgroundTool
is well-implemented and aligns with the stated goal. However, the implementation for making AspectRatioTool
vertically scrollable introduces a potential issue with conflicting scroll behaviors. I've left a comment detailing the problem and suggesting a fix. With that addressed, these changes will be a good improvement for adaptive layouts.
This commit makes the following changes: