Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cache class to separate caching logic from TasksRepository Fixes #522 #523

Open
wants to merge 2 commits into
base: todo-mvp
Choose a base branch
from
Open

Conversation

jeffmcnd
Copy link

@jeffmcnd jeffmcnd commented Mar 6, 2018

This commit adds a new class that handles Task caching. This change
pulls the logic for caching out of the TasksRepository to more closely
adhere to the Single Responsibility Principle (SRP). Now the repository
need not worry about null cache objects, iterating through the cache, or
keeping track of whether the cache is dirty or not.

jeffmcnd added 2 commits March 6, 2018 14:09
This commit adds a new class that handles Task caching. This change
pulls the logic for caching out of the TasksRepository to more closely
adhere to the Single Responsibility Principle (SRP). Now the repository
need not worry about null cache objects, iterating through the cache, or
keeping track of whether the cache is dirty or not.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

@jeffmcnd
Copy link
Author

jeffmcnd commented Mar 6, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants