Skip to content

Added color in colors.xml for activity embedding snippets. #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ahmedpro25
Copy link

No description provided.

@Copilot Copilot AI review requested due to automatic review settings June 5, 2025 08:58
Copy link

google-cla bot commented Jun 5, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a dedicated color resource for activity embedding snippets and annotates its purpose.

  • Introduce a comment to note the new color’s usage context.
  • Add divider_color with semi-transparent white for snippet dividers.
Comments suppressed due to low confidence (3)

misc/src/main/res/values/colors.xml:10

  • [nitpick] The comment is very brief; consider elaborating to clarify exactly where this color is applied, for example: 'Divider in activity embedding preview snippets.'
<!-- For activity embedding snippets. -->

misc/src/main/res/values/colors.xml:11

  • [nitpick] Resource name divider_color is quite generic and may collide with other dividers; consider a more specific name like activity_embedding_divider_color or snippet_divider_color.
<color name="divider_color">#AAFFFFFF</color>

misc/src/main/res/values/colors.xml:11

  • Semi-transparent white (#AAFFFFFF) might not meet contrast requirements on all backgrounds; verify it satisfies accessibility contrast guidelines in its intended context.
<color name="divider_color">#AAFFFFFF</color>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants