Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] develop from leonlatsch:develop #54

Merged
merged 4 commits into from
May 28, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revoke ACCESS_NETWORK_STATE (leonlatsch#311)
**Description:**

The Exoplayer Core library requests the ACCESS_NETWORK_STATE permission
by default.

With a newer release of exoplayer its possible to revoke it
[commit](google/ExoPlayer@0a74e36)

Issue by someone having the same problem
google/ExoPlayer#6019

closes leonlatsch#310 


**Tasks:**
- [x] Revoke permission
- [x] Test if video player works fine
  • Loading branch information
leonlatsch authored May 28, 2024
commit ba69f1606ea49bc995ec3f8a97852ac0fa03203c
2 changes: 2 additions & 0 deletions app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@
<uses-permission android:name="android.permission.READ_MEDIA_VIDEO" />
<uses-permission android:name="android.permission.READ_MEDIA_IMAGES" />

<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" tools:node="remove"/>

<application
android:name=".BaseApplication"
android:allowBackup="false"
Expand Down