Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize and simplify #80

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Modernize and simplify #80

wants to merge 3 commits into from

Conversation

dchenk
Copy link

@dchenk dchenk commented Jun 3, 2024

Hello. This PR includes kind of a lot in it, so I apologize in advance. But I think all the changes help make this library more robust and up-to-date with best practices.

Major changes:

  • A named createSubscriber function export rather than a default.
  • ES Module only (on CommonJS).
  • Removed TypedEventEmitter for better runtime type safety. The rationale is that TypedEventEmitter purely type asserts, but in practice you could technically get any sort of payload for notification events. Along with this change I've replaced all instances of the any type with unknown.

Also, internal changes:

  • Use GitHub Actions instead of Travis CI.
  • Replace TSLint with ESLint.
  • Upgraded TypeScript and all other dependencies.
  • Changed to Vitest for the test framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant