Merge pull request #77 from sumitparakh/issue76

bug(serve): project contains old/deprecated ng serve flags
angular-klingon · Nov 28, 2018 · 5daf999 · 5daf999
2 parents 12a4f80 + 78b43a2
commit 5daf999
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 36 deletions.
diff --git a/packages/klingon-ui/src/app/cli/cli.service.ts b/packages/klingon-ui/src/app/cli/cli.service.ts
@@ -39,7 +39,8 @@ export class CliService {
           values[key] !== '' &&
           key !== 'app-name' &&
           key !== 'root-dir' &&
-          key !== 'dir'
+          key !== 'dir' &&
+          key !== 'app'
       )
       .map(key => `--${key}=${values[key]}`)
       .join(' ');

diff --git a/packages/klingon-ui/src/app/cli/flags/flags.component.ts b/packages/klingon-ui/src/app/cli/flags/flags.component.ts
@@ -83,17 +83,13 @@ export class FlagsComponent implements OnInit {
         'base-href': new FormControl('/'),
         'proxy-config': new FormControl(''),
         'deploy-url': new FormControl(),
-        environment: new FormControl(this.environments[0]),
-        'extract-css': new FormControl(false),
         'i18n-file': new FormControl(),
         'i18n-format': new FormControl(),
         locale: new FormControl(),
-        'output-hashing': new FormControl(false),
         'output-path': new FormControl(),
         poll: new FormControl(),
         progress: new FormControl(true),
-        sourcemap: new FormControl(true),
-        target: new FormControl(this.targets[0]),
+        // target: new FormControl(this.targets[0]),
         'vendor-chunk': new FormControl(true),
         verbose: new FormControl(false),
         watch: new FormControl(false)

diff --git a/packages/klingon-ui/src/app/cli/serve/serve.component.html b/packages/klingon-ui/src/app/cli/serve/serve.component.html
@@ -96,14 +96,6 @@ <h6 class="sub-title">Configure other flags for the serve command</h6>
                     <mat-hint align="start">Enable and define the file watching poll time period (milliseconds).</mat-hint>
                 </mat-form-field>
             </p>
-            <p>
-                <mat-hint class="fixe-height" align="start">Defines the build environment:</mat-hint>
-                <mat-select formControlName="environment">
-                    <mat-option *ngFor="let env of environments" [value]="env">
-                        {{ env }}
-                    </mat-option>
-                </mat-select>
-            </p>
             <p>
                 <mat-hint class="fixe-height" align="start">Format of the localization file specified with --i18n-file:</mat-hint>
                 <mat-select formControlName="i18n-format">
@@ -120,22 +112,6 @@ <h6 class="sub-title">Configure other flags for the serve command</h6>
                     </mat-option>
                 </mat-select>
             </p>
-            <p>
-                <mat-hint class="fixe-height" align="start">Define the output filename cache-busting hashing mode:</mat-hint>
-                <mat-select formControlName="output-hashing">
-                    <mat-option *ngFor="let hash of hashings" [value]="hash">
-                        {{ hash }}
-                    </mat-option>
-                </mat-select>
-            </p>
-            <p>
-                <mat-hint class="fixe-height" align="start">Define the output filename cache-busting hashing mode:</mat-hint>
-                <mat-select formControlName="target">
-                    <mat-option *ngFor="let target of targets" [value]="target">
-                        {{ target }}
-                    </mat-option>
-                </mat-select>
-            </p>
             <mat-list>
                 <mat-list-item>
                     <mat-checkbox formControlName="open">Opens the url in default browser</mat-checkbox>
@@ -146,9 +122,6 @@ <h6 class="sub-title">Configure other flags for the serve command</h6>
                 <mat-list-item>
                     <mat-checkbox formControlName="aot">Build using Ahead of Time compilation</mat-checkbox>
                 </mat-list-item>
-                <mat-list-item>
-                    <mat-checkbox formControlName="extract-css">Extract css from global styles onto css files instead of js ones</mat-checkbox>
-                </mat-list-item>
                 <mat-list-item>
                     <mat-checkbox formControlName="hmr">Enable hot module replacement (HMR).</mat-checkbox>
                 </mat-list-item>
@@ -158,9 +131,6 @@ <h6 class="sub-title">Configure other flags for the serve command</h6>
                 <mat-list-item>
                     <mat-checkbox formControlName="progress">Log progress to the console while building</mat-checkbox>
                 </mat-list-item>
-                <mat-list-item>
-                    <mat-checkbox formControlName="sourcemap">Output sourcemaps</mat-checkbox>
-                </mat-list-item>
                 <mat-list-item>
                     <mat-checkbox formControlName="vendor-chunk">Use a separate bundle containing only vendor libraries</mat-checkbox>
                 </mat-list-item>