Stablize CI tests #30669
Merged
Stablize CI tests #30669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
area: build & ci
alan-agius4
force-pushed
the
test-size-medium
branch
from
780f481 to
267bd7b
Compare
alan-agius4
changed the title
alan-agius4
force-pushed
the
test-size-medium
branch
5 times, most recently
from
c3471a2 to
5af5262
Compare
alan-agius4
added
the
target: rc
alan-agius4
force-pushed
the
test-size-medium
branch
5 times, most recently
from
c517191 to
01beccc
Compare
alan-agius4
force-pushed
the
test-size-medium
branch
4 times, most recently
from
2b9cdc1 to
e586379
Compare
alan-agius4
changed the title
There are several warnings about tests whose specified size is too big. These tests shards run under 300s and thus `medium` is more appropiate.
… the builder This is needed as a workaround for angular#28271
These test do not need the contents of the `main.ts`
The default 2.5-minute timeout is often unnecessary and can interfere with test execution. Specifically, Bazel may terminate the test before Jasmine does, making it harder to identify which test is causing the issue.
Significantly reduces the number of application builds performed in this test
alan-agius4
force-pushed
the
test-size-medium
branch
from
59a1bb2 to
2f6495b
Compare
alan-agius4
added
the
action: review
jkrems
approved these changes
Jul 8, 2025
| // Default timeout for large specs is 2.5 minutes. | ||
| jasmine.DEFAULT_TIMEOUT_INTERVAL = 150000; | ||
| // Default timeout for large specs is 60s. | ||
| jasmine.DEFAULT_TIMEOUT_INTERVAL = 60_000; |
There was a problem hiding this comment.
❤️ Always great to see these decrease!
packages/angular/build/src/builders/application/tests/options/output-path_spec.ts
Show resolved
Hide resolved
alan-agius4
added
action: merge
|
The changes were merged into the following branches: main, 20.1.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See each commit