-
Notifications
You must be signed in to change notification settings - Fork 11.9k
feat(@schematics/angular): add schematics to generate ai context files #30763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
packages/schematics/angular/ai-config/files/__rulesName__.template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
<% if (frontmatter) { %><%= frontmatter %> | ||
|
||
<% } %>You are an expert in TypeScript, Angular, and scalable web application development. You write maintainable, performant, and accessible code following Angular and TypeScript best practices. | ||
|
||
## TypeScript Best Practices | ||
|
||
- Use strict type checking | ||
- Prefer type inference when the type is obvious | ||
- Avoid the `any` type; use `unknown` when type is uncertain | ||
|
||
## Angular Best Practices | ||
|
||
- Always use standalone components over NgModules | ||
- Must NOT set `standalone: true` inside Angular decorators. It's the default. | ||
- Use signals for state management | ||
- Implement lazy loading for feature routes | ||
- Do NOT use the `@HostBinding` and `@HostListener` decorators. Put host bindings inside the `host` object of the `@Component` or `@Directive` decorator instead | ||
- Use `NgOptimizedImage` for all static images. | ||
- `NgOptimizedImage` does not work for inline base64 images. | ||
|
||
## Components | ||
|
||
- Keep components small and focused on a single responsibility | ||
- Use `input()` and `output()` functions instead of decorators | ||
- Use `computed()` for derived state | ||
- Set `changeDetection: ChangeDetectionStrategy.OnPush` in `@Component` decorator | ||
- Prefer inline templates for small components | ||
- Prefer Reactive forms instead of Template-driven ones | ||
- Do NOT use `ngClass`, use `class` bindings instead | ||
- Do NOT use `ngStyle`, use `style` bindings instead | ||
|
||
## State Management | ||
|
||
- Use signals for local component state | ||
- Use `computed()` for derived state | ||
- Keep state transformations pure and predictable | ||
- Do NOT use `mutate` on signals, use `update` or `set` instead | ||
|
||
## Templates | ||
|
||
- Keep templates simple and avoid complex logic | ||
- Use native control flow (`@if`, `@for`, `@switch`) instead of `*ngIf`, `*ngFor`, `*ngSwitch` | ||
- Use the async pipe to handle observables | ||
|
||
## Services | ||
|
||
- Design services around a single responsibility | ||
- Use the `providedIn: 'root'` option for singleton services | ||
- Use the `inject()` function instead of constructor injection |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
/** | ||
* @license | ||
* Copyright Google LLC All Rights Reserved. | ||
* | ||
* Use of this source code is governed by an MIT-style license that can be | ||
* found in the LICENSE file at https://angular.dev/license | ||
*/ | ||
|
||
import { | ||
Rule, | ||
apply, | ||
applyTemplates, | ||
chain, | ||
mergeWith, | ||
move, | ||
noop, | ||
strings, | ||
url, | ||
} from '@angular-devkit/schematics'; | ||
import { Schema as ConfigOptions, Tool } from './schema'; | ||
|
||
type ToolWithoutNone = Exclude<Tool, Tool.None>; | ||
|
||
const AI_TOOLS: { [key in ToolWithoutNone]: ContextFileInfo } = { | ||
gemini: { | ||
rulesName: 'GEMINI.md', | ||
directory: '.gemini', | ||
}, | ||
claude: { | ||
rulesName: 'CLAUDE.md', | ||
directory: '.claude', | ||
}, | ||
copilot: { | ||
rulesName: 'copilot-instructions.md', | ||
directory: '.github', | ||
}, | ||
windsurf: { | ||
rulesName: 'guidelines.md', | ||
directory: '.windsurf/rules', | ||
}, | ||
jetbrains: { | ||
rulesName: 'guidelines.md', | ||
directory: '.junie', | ||
}, | ||
// Cursor file has a front matter section. | ||
cursor: { | ||
rulesName: 'cursor.mdc', | ||
directory: '.cursor/rules', | ||
frontmatter: `---\ncontext: true\npriority: high\nscope: project\n---`, | ||
}, | ||
}; | ||
|
||
interface ContextFileInfo { | ||
rulesName: string; | ||
directory: string; | ||
frontmatter?: string; | ||
} | ||
|
||
export default function ({ tool }: ConfigOptions): Rule { | ||
if (!tool || tool.includes(Tool.None)) { | ||
return noop(); | ||
} | ||
|
||
const files: ContextFileInfo[] = (tool as ToolWithoutNone[]).map( | ||
(selectedTool) => AI_TOOLS[selectedTool], | ||
); | ||
|
||
const rules = files.map(({ rulesName, directory, frontmatter }) => | ||
mergeWith( | ||
apply(url('./files'), [ | ||
applyTemplates({ | ||
...strings, | ||
rulesName, | ||
frontmatter, | ||
}), | ||
move(directory), | ||
]), | ||
), | ||
); | ||
|
||
return chain(rules); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
/** | ||
* @license | ||
* Copyright Google LLC All Rights Reserved. | ||
* | ||
* Use of this source code is governed by an MIT-style license that can be | ||
* found in the LICENSE file at https://angular.dev/license | ||
*/ | ||
|
||
import { SchematicTestRunner, UnitTestTree } from '@angular-devkit/schematics/testing'; | ||
import { Schema as WorkspaceOptions } from '../workspace/schema'; | ||
import { Schema as ConfigOptions, Tool as ConfigTool } from './schema'; | ||
|
||
describe('Ai Config Schematic', () => { | ||
const schematicRunner = new SchematicTestRunner( | ||
'@schematics/angular', | ||
require.resolve('../collection.json'), | ||
); | ||
|
||
const workspaceOptions: WorkspaceOptions = { | ||
name: 'workspace', | ||
newProjectRoot: 'projects', | ||
version: '15.0.0', | ||
}; | ||
|
||
let workspaceTree: UnitTestTree; | ||
function runConfigSchematic(tool: ConfigTool[]): Promise<UnitTestTree> { | ||
return schematicRunner.runSchematic<ConfigOptions>('ai-config', { tool }, workspaceTree); | ||
} | ||
|
||
beforeEach(async () => { | ||
workspaceTree = await schematicRunner.runSchematic('workspace', workspaceOptions); | ||
}); | ||
|
||
it('should create a GEMINI.MD file', async () => { | ||
JeanMeche marked this conversation as resolved.
Show resolved
Hide resolved
|
||
const tree = await runConfigSchematic([ConfigTool.Gemini]); | ||
expect(tree.exists('.gemini/GEMINI.md')).toBeTruthy(); | ||
}); | ||
|
||
it('should create a copilot-instructions.md file', async () => { | ||
const tree = await runConfigSchematic([ConfigTool.Copilot]); | ||
expect(tree.exists('.github/copilot-instructions.md')).toBeTruthy(); | ||
}); | ||
|
||
it('should create a cursor file', async () => { | ||
const tree = await runConfigSchematic([ConfigTool.Cursor]); | ||
expect(tree.exists('.cursor/rules/cursor.mdc')).toBeTruthy(); | ||
}); | ||
|
||
it('should create a windsurf file', async () => { | ||
const tree = await runConfigSchematic([ConfigTool.Windsurf]); | ||
expect(tree.exists('.windsurf/rules/guidelines.md')).toBeTruthy(); | ||
}); | ||
|
||
it('should create a claude file', async () => { | ||
const tree = await runConfigSchematic([ConfigTool.Claude]); | ||
expect(tree.exists('.claude/CLAUDE.md')).toBeTruthy(); | ||
}); | ||
|
||
it('should create a jetbrains file', async () => { | ||
const tree = await runConfigSchematic([ConfigTool.Jetbrains]); | ||
expect(tree.exists('.junie/guidelines.md')).toBeTruthy(); | ||
}); | ||
|
||
it('should create multiple files when multiple tools are selected', async () => { | ||
const tree = await runConfigSchematic([ | ||
ConfigTool.Gemini, | ||
ConfigTool.Copilot, | ||
ConfigTool.Cursor, | ||
]); | ||
expect(tree.exists('.gemini/GEMINI.md')).toBeTruthy(); | ||
expect(tree.exists('.github/copilot-instructions.md')).toBeTruthy(); | ||
expect(tree.exists('.cursor/rules/cursor.mdc')).toBeTruthy(); | ||
}); | ||
|
||
it('should error is None is associated with other values', () => { | ||
return expectAsync(runConfigSchematic([ConfigTool.None, ConfigTool.Cursor])).toBeRejected(); | ||
}); | ||
|
||
it('should not create any files if None is selected', async () => { | ||
const filesCount = workspaceTree.files.length; | ||
const tree = await runConfigSchematic([ConfigTool.None]); | ||
expect(tree.files.length).toBe(filesCount); | ||
}); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
{ | ||
"$schema": "http://json-schema.org/draft-07/schema", | ||
"$id": "SchematicsAngularAIConfig", | ||
"title": "Angular AI Config File Options Schema", | ||
"type": "object", | ||
"additionalProperties": false, | ||
"description": "Generates AI configuration files for Angular projects. This schematic creates configuration files that help AI tools follow Angular best practices, improving the quality of AI-generated code and suggestions.", | ||
"properties": { | ||
"tool": { | ||
"type": "array", | ||
"uniqueItems": true, | ||
alan-agius4 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"default": "none", | ||
"x-prompt": "Which AI tools do you want to configure with Angular best practices? https://angular.dev/ai/develop-with-ai", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. NIT: As a follow up can we improve the prompt to include some more details
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will take care of it in a follow up. |
||
"description": "Specifies which AI tools to generate configuration files for. These file are used to improve the outputs of AI tools by following the best practices.", | ||
"minItems": 1, | ||
"items": { | ||
"type": "string", | ||
"enum": ["none", "gemini", "copilot", "claude", "cursor", "jetbrains", "windsurf"] | ||
} | ||
} | ||
}, | ||
"if": { | ||
"properties": { | ||
"tool": { | ||
"contains": { | ||
"const": "none" | ||
} | ||
} | ||
}, | ||
"required": ["tool"] | ||
}, | ||
"then": { | ||
"properties": { | ||
"tool": { | ||
"maxItems": 1 | ||
} | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.