Skip to content

refactor(@angular/cli): remove usage of npm-pick-manifest dependency #30784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025

Conversation

clydin
Copy link
Member

@clydin clydin commented Jul 24, 2025

The amount of used functionality provided by the npm-pick-manifest package was minimal within the Angular CLI. Logic to determine an appropriate package version for ng update is similar to the logic in ng add. The later of which did not use the npm-pick-manifest package. To reduce the total amount of dependencies, the logic from ng add was repurposed to fit the requirements of ng update.

@clydin clydin added the target: minor This PR is targeted for the next minor release label Jul 24, 2025
@clydin clydin force-pushed the cli/remove-npm-pick-manifest branch 2 times, most recently from fbf0f73 to f764984 Compare July 24, 2025 21:16
The amount of used functionality provided by the `npm-pick-manifest` package
was minimal within the Angular CLI. Logic to determine an appropriate
package version for `ng update` is similar to the logic in `ng add`.
The later of which did not use the `npm-pick-manifest` package. To reduce
the total amount of dependencies, the logic from `ng add` was repurposed
to fit the requirements of `ng update`.
@clydin clydin force-pushed the cli/remove-npm-pick-manifest branch from f764984 to 8f160e8 Compare July 24, 2025 21:17
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 24, 2025
@clydin clydin requested a review from alan-agius4 July 25, 2025 10:12
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 25, 2025
@clydin clydin merged commit ffbbb66 into angular:main Jul 25, 2025
31 of 32 checks passed
@clydin clydin deleted the cli/remove-npm-pick-manifest branch July 25, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/cli target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants