refactor(@angular/cli): enhance JSON file handling and utility functions #30828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a number of significant improvements to the core utility functions, with a primary focus on enhancing the robustness and developer experience of `JSONFile`. The `JSONFile` class now automatically detects and preserves file indentation, uses native private fields for better encapsulation, and includes a new `delete()` method for a more intuitive API. Additionally, the `readAndParseJson` and `parseJson` functions are now generic for improved type-safety. The `assertIsError` utility is more robust, and a type-related bug in workspace configuration validation has been fixed. All related utilities have been updated with comprehensive JSDoc comments.
clydin
added
the
action: review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a number of significant improvements to the core utility functions, with a primary focus on enhancing the robustness and developer experience of
JSONFile.The
JSONFileclass now automatically detects and preserves file indentation, uses native private fields for better encapsulation, and includes a newdelete()method for a more intuitive API.Additionally, the
readAndParseJsonandparseJsonfunctions are now generic for improved type-safety. TheassertIsErrorutility is more robust, and a type-related bug in workspace configuration validation has been fixed. All related utilities have been updated with comprehensive JSDoc comments.