Skip to content

Conversation

alan-agius4
Copy link
Collaborator

No description provided.

@alan-agius4 alan-agius4 requested a review from crisbeto August 28, 2025 07:26
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Aug 28, 2025
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Aug 28, 2025
@alan-agius4 alan-agius4 force-pushed the ts-patch-match branch 2 times, most recently from 03c602d to 285a2b0 Compare August 28, 2025 08:00
Within our module.bazel file when describing the version of typescript to use for rules_ts, we use ts_version instead of ts_version_from to prevent our package.json file from being
part of the set of files used to calculate the sha for the lock file.  Any unrelated change to the version of the typescript file would end up causing our lockfile to be out of date.
This amount of churn has proven to be too much for our current setup. We instead now test to validate the versions defined in the package.json and MODULE.bazel files match.
@alan-agius4 alan-agius4 merged commit 391eb32 into angular:20.2.x Aug 28, 2025
31 checks passed
@alan-agius4 alan-agius4 deleted the ts-patch-match branch August 28, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants