Skip to content

Commit

Permalink
remove intro.js (highlight#5892)
Browse files Browse the repository at this point in the history
## Summary

<!--
Ideally, there is an attached GitHub issue that will describe the "why".

If relevant, use this section to call out any additional information
you'd like to _highlight_ to the reviewer.
-->

Remove intro js (along with the `PlayerPageProductTour` component). We
don't use this anymore and it may be causing unintended errors in our
app.

## How did you test this change?

<!--
Frontend - Leave a screencast or a screenshot to visually describe the
changes.
-->

Frontend loads as expected.

## Are there any deployment considerations?

<!--
 Backend - Do we need to consider migrations or backfilling data?
-->
  • Loading branch information
et authored Jul 12, 2023
1 parent 223242a commit 1910641
Show file tree
Hide file tree
Showing 7 changed files with 53 additions and 240 deletions.
3 changes: 0 additions & 3 deletions .reflame.config.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -288,9 +288,6 @@
"firebase": {
"entryPoints": ["/compat/auth", "/compat/app"],
},
"intro.js": {
"entryPoints": ["/", "/introjs.css"],
},
"lodash": {
"entryPoints": ["/", "/isEqual"],
},
Expand Down
2 changes: 0 additions & 2 deletions frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@
"graphql": "^15.5.0",
"highlight.io": "workspace:*",
"highlight.run": "workspace:*",
"intro.js": "^4.1.0",
"intro.js-react": "^0.6.0",
"js-cookie": "^3.0.1",
"lodash": "^4.17.21",
"lottie-react": "^2.1.0",
Expand Down
102 changes: 51 additions & 51 deletions frontend/src/__generated/index.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions frontend/src/pages/Player/PlayerPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import {
useLinkLogCursor,
} from '@pages/Player/PlayerHook/utils'
import usePlayerConfiguration from '@pages/Player/PlayerHook/utils/usePlayerConfiguration'
import PlayerPageProductTour from '@pages/Player/PlayerPageProductTour/PlayerPageProductTour'
import {
ReplayerContextProvider,
ReplayerState,
Expand All @@ -37,7 +36,6 @@ import {
} from '@pages/Player/ResourcesContext/ResourcesContext'
import RightPlayerPanel from '@pages/Player/RightPlayerPanel/RightPlayerPanel'
import SessionLevelBarV2 from '@pages/Player/SessionLevelBar/SessionLevelBarV2'
import { DevTools } from '@pages/Player/Toolbar/DevTools'
import { Tab } from '@pages/Player/Toolbar/DevToolsWindowV2/utils'
import { NewCommentModal } from '@pages/Player/Toolbar/NewCommentModal/NewCommentModal'
import { Toolbar } from '@pages/Player/Toolbar/Toolbar'
Expand All @@ -58,6 +56,7 @@ import { useNavigate } from 'react-router-dom'

import { DEMO_PROJECT_ID } from '@/components/DemoWorkspaceButton/DemoWorkspaceButton'
import { NetworkResourcePanel } from '@/pages/Player/RightPlayerPanel/components/NetworkResourcePanel/NetworkResourcePanel'
import DevToolsWindowV2 from '@/pages/Player/Toolbar/DevToolsWindowV2/DevToolsWindowV2'
import { useIntegratedLocalStorage } from '@/util/integrated'

import WaitingAnimation from '../../lottie/waiting.json'
Expand Down Expand Up @@ -356,7 +355,7 @@ const PlayerPage = () => {
</div>
<Toolbar width={controllerWidth} />
</div>
<DevTools width={controllerWidth} />
<DevToolsWindowV2 width={controllerWidth} />
</div>
{!isPlayerFullscreen && <RightPlayerPanel />}
<NetworkResourcePanel />
Expand Down Expand Up @@ -483,7 +482,6 @@ const PlayerPage = () => {
<Helmet>
<title>{getTabTitle(session)}</title>
</Helmet>
{isPlayerReady && !isLoggedIn && <PlayerPageProductTour />}
<Box
cssClass={clsx(style.playerBody, {
[style.withLeftPanel]: showLeftPanel,
Expand Down

This file was deleted.

16 changes: 0 additions & 16 deletions frontend/src/pages/Player/Toolbar/DevTools.tsx

This file was deleted.

19 changes: 0 additions & 19 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -11480,8 +11480,6 @@ __metadata:
happy-dom: ^6.0.4
highlight.io: "workspace:*"
highlight.run: "workspace:*"
intro.js: ^4.1.0
intro.js-react: ^0.6.0
js-cookie: ^3.0.1
jsonc-parser: ^3.2.0
less: ^4.1.3
Expand Down Expand Up @@ -35067,23 +35065,6 @@ __metadata:
languageName: node
linkType: hard

"intro.js-react@npm:^0.6.0":
version: 0.6.0
resolution: "intro.js-react@npm:0.6.0"
peerDependencies:
intro.js: ">=2.5.0"
react: ">=0.14.0"
checksum: f90a74297d69fc13bfc43600c614826869618f80cc9e1bbd7e2e44c04d253039047bd2d7c9cc57289b52ea0e65e2d24d7fa6b87ea0e95fbc6d3aa3719715a40c
languageName: node
linkType: hard

"intro.js@npm:^4.1.0":
version: 4.1.0
resolution: "intro.js@npm:4.1.0"
checksum: 30b68b85fbc48f465759dd6c9b3f49886f4fd2a57d43ea01c2313c77896d4d5504a726b7729a0ebb0f1d027c20c73ca80b19186a19ce777d92230efad8089757
languageName: node
linkType: hard

"invariant@npm:^2.2.4":
version: 2.2.4
resolution: "invariant@npm:2.2.4"
Expand Down

0 comments on commit 1910641

Please sign in to comment.