Skip to content

Commit

Permalink
Standardize Reflame config formatting (highlight#6051)
Browse files Browse the repository at this point in the history
## Summary

I've been working on a new feature to programmatically update the
Reflame config based on the NPM package entry points that are actually
used (sneak peak
[here](lewisl9029@05c4b7f)).
Realized that we need to take over formatting duties for the config from
individual projects' prettier configurations, or otherwise there will
always be discrepancies between our programmatic updates and prettier
output, leading to issues in CI. This PR formats the config according to
our new standard and updates prettier configs to ignore it to prevent CI
failures.

Prettier's handling of jsonc files was a bit of a hack anyways (it's
actually treating it as json5, which can result in subtle bugs and
inconsistencies), so this should also make the formatting a bit more
robust going forward.

<!--
Ideally, there is an attached GitHub issue that will describe the "why".

If relevant, use this section to call out any additional information
you'd like to _highlight_ to the reviewer.
-->

## How did you test this change?

<!--
Frontend - Leave a screencast or a screenshot to visually describe the
changes.
-->

## Are there any deployment considerations?

<!--
 Backend - Do we need to consider migrations or backfilling data?
-->
  • Loading branch information
lewisl9029 authored Jul 21, 2023
1 parent b61f4da commit 33f97e2
Show file tree
Hide file tree
Showing 4 changed files with 406 additions and 368 deletions.
1 change: 1 addition & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,4 @@ scripts/venv
**/.eslintrc.json
.yarnrc.yml
__generated
.reflame.config.jsonc
13 changes: 1 addition & 12 deletions .prettierrc
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,5 @@
"arrowParens": "always",
"requirePragma": false,
"insertPragma": false,
"proseWrap": "preserve",
"overrides": [
{
"files": [".reflame.config.jsonc"],
"options": {
"parser": "json5",
"quoteProps": "preserve",
"singleQuote": false,
"trailingComma": "all"
}
}
]
"proseWrap": "preserve"
}
Loading

0 comments on commit 33f97e2

Please sign in to comment.