Skip to content

Commit

Permalink
Remove obsolete overrides, pin versions for problematic packages (hig…
Browse files Browse the repository at this point in the history
…hlight#5844)

## Summary

I just shipped a huge rework to the way we process npm packages (bumping
versions should now take closer to 10s for this repo, compared to ~40s
before 🥳 ), and it happened to also remove the need for many of the
overrides we were using before.

We were also using overrides to pin to specific versions for
dependencies that had incompatible versions, but I realized we should
probably be pinning those in package.json instead of Reflame overrides
to make sure they stay consistent across Vite and Reflame.

<!--
Ideally, there is an attached GitHub issue that will describe the "why".

If relevant, use this section to call out any additional information
you'd like to _highlight_ to the reviewer.
-->

## How did you test this change?

In Reflame previews.

<!--
Frontend - Leave a screencast or a screenshot to visually describe the
changes.
-->

## Are there any deployment considerations?

<!--
 Backend - Do we need to consider migrations or backfilling data?
-->
  • Loading branch information
lewisl9029 authored Jul 10, 2023
1 parent b66e47a commit e52d857
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 14 deletions.
8 changes: 0 additions & 8 deletions .reflame.config.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -350,12 +350,4 @@
"entryPoints": ["/", "/adapters/react-router-6"],
},
},
"npmPackageOverrides": {
"react": "18.2.0",
"react-dom": "18.2.0",
"graphql": "16.6.0",
"react-transition-group": "4.4.1",
"lodash": "npm:lodash-es",
"antd": "4.21.7",
},
}
4 changes: 2 additions & 2 deletions frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"@tanstack/react-table": "^8.7.9",
"@tanstack/react-virtual": "3.0.0-beta.52",
"@vanilla-extract/recipes": "^0.4.0",
"antd": "^4.17.0",
"antd": "4.21.7",
"ariakit": "^2.0.0-next.41",
"clsx": "^1.2.1",
"color-hash": "^2.0.1",
Expand Down Expand Up @@ -59,7 +59,7 @@
"react-markdown": "^8.0.5",
"react-nice-avatar": "^1.2.1",
"react-resizable": "^3.0.4",
"react-resize-aware": "^3.0.1",
"react-resize-aware": "3.1.0",
"react-router-dom": "^6.8.1",
"react-select": "^3.1.1",
"react-slider": "^2.0.1",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -11275,7 +11275,7 @@ __metadata:
"@vanilla-extract/recipes": ^0.4.0
"@vanilla-extract/vite-plugin": ^3.7.0
"@vitejs/plugin-react-swc": ^3.0.1
antd: ^4.17.0
antd: 4.21.7
ariakit: ^2.0.0-next.41
autoprefixer: ^10.4.8
clsx: ^1.2.1
Expand Down Expand Up @@ -11332,7 +11332,7 @@ __metadata:
react-markdown: ^8.0.5
react-nice-avatar: ^1.2.1
react-resizable: ^3.0.4
react-resize-aware: ^3.0.1
react-resize-aware: 3.1.0
react-router-dom: ^6.8.1
react-select: ^3.1.1
react-slider: ^2.0.1
Expand Down Expand Up @@ -22933,7 +22933,7 @@ __metadata:
languageName: node
linkType: hard

"antd@npm:^4.17.0":
"antd@npm:4.21.7":
version: 4.21.7
resolution: "antd@npm:4.21.7"
dependencies:
Expand Down Expand Up @@ -46049,7 +46049,7 @@ __metadata:
languageName: node
linkType: hard

"react-resize-aware@npm:^3.0.1":
"react-resize-aware@npm:3.1.0":
version: 3.1.0
resolution: "react-resize-aware@npm:3.1.0"
peerDependencies:
Expand Down

0 comments on commit e52d857

Please sign in to comment.