Chore: Set Docker image tag to latest only when really latest (Rocket…

…Chat#24366)

.docker/Dockerfile.alpine

@@ -4,19 +4,19 @@ RUN apk add --no-cache python3 make g++ libc6-compat ttf-dejavu
 
 ADD . /app
 
-MAINTAINER [email protected]
+LABEL maintainer="[email protected]"
 
 RUN set -x \
- && cd /app/bundle/programs/server \
- && npm install --production \
- # Start hack for sharp...
- && rm -rf npm/node_modules/sharp \
- && npm install [email protected] \
- && mv node_modules/sharp npm/node_modules/sharp \
- # End hack for sharp
- && cd npm \
- && npm rebuild bcrypt --build-from-source \
- && npm cache clear --force
+    && cd /app/bundle/programs/server \
+    && npm install --production \
+    # Start hack for sharp...
+    && rm -rf npm/node_modules/sharp \
+    && npm install [email protected] \
+    && mv node_modules/sharp npm/node_modules/sharp \
+    # End hack for sharp
+    && cd npm \
+    && npm rebuild bcrypt --build-from-source \
+    && npm cache clear --force
 
 # needs a mongo instance - defaults to container linking with alias 'mongo'
 ENV DEPLOY_METHOD=docker \

.github/workflows/build_and_test.yml

@@ -565,9 +565,20 @@ jobs:
         docker build -t $IMAGE_NAME:$DOCKER_TAG .
         docker push $IMAGE_NAME:$DOCKER_TAG
 
-        # build and push the broader alias tag
-        docker tag $IMAGE_NAME:$DOCKER_TAG $IMAGE_NAME:$RELEASE
-        docker push $IMAGE_NAME:$RELEASE
+        if [[ $RELEASE == 'latest' ]]; then
+          CURRENT_LATEST="$(
+            git -c 'versionsort.suffix=-' ls-remote -t --exit-code --refs --sort=-v:refname "https://github.com/$GITHUB_REPOSITORY" '*' |
+              sed -En '1!q;s/^[[:xdigit:]]+[[:space:]]+refs\/tags\/(.+)/\1/gp'
+          )"
+          echo "CURRENT_LATEST: $CURRENT_LATEST"
+          if [[ $CURRENT_LATEST == $GITHUB_REF_NAME ]]; then
+            docker tag $IMAGE_NAME:$DOCKER_TAG $IMAGE_NAME:$RELEASE
+            docker push $IMAGE_NAME:$RELEASE
+          fi
+        else
+          docker tag $IMAGE_NAME:$DOCKER_TAG $IMAGE_NAME:$RELEASE
+          docker push $IMAGE_NAME:$RELEASE
+        fi
 
     - name: Build Docker image for develop
       if: github.ref == 'refs/heads/develop'