Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: WidgetSmall redesign non material you #17909

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Rdkang
Copy link
Contributor

@Rdkang Rdkang commented Feb 1, 2025

Purpose / Description

Update small widget design for SDK versions below v31 with the Material You design (using static, not dynamic, colors). This will improve design consistency and simplify the codebase.

Fixes

Approach

Updated the design

  1. Widget with reviews due
  1. Widget when no cards to review, the star on the logo will be darker

How Has This Been Tested?

Virtual pixel 3 on SDK 28 and pixel 7 on SDK 35

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@xenonnn4w
Copy link
Contributor

Thanks! Looks awesome. Tested on API 25 and API 28 works fine.
Here the only thing which is quite different was the size of circle_background which depends on the grid layout (was unable to change in these lower api's ) so i don't think it can be fixed. Rest it look awesome again.
image
image

@xenonnn4w
Copy link
Contributor

xenonnn4w commented Feb 2, 2025

Also add the parameters android:previewLayout (for API>31 ) and android:previewImage (for API<=31) in the widget_provider_small file so we can have the same widget looks as you made in the widget picker screen.

@xenonnn4w xenonnn4w added the Needs Author Reply Waiting for a reply from the original author label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Author Reply Waiting for a reply from the original author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Themed Widgets
2 participants