fix(chart): resolve issue #6544 with line chart sorting #6621
+3,437
−205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes issue antvis#6544 by: - Implementing proper domain-based sorting in the sortQuantitative transform - Adding support for slicing sorted domains - Creating a test case that demonstrates the fix - Enhancing the sort transform to handle sorting by a different channel than the one being displayed
Pull Request Test Coverage Report for Build 13653244175Details
💛 - Coveralls |
pearmini
requested changes
Mar 1, 2025
pearmini
approved these changes
Mar 4, 2025
|
@pearmini 没有问题，可行的话，我就合并了。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes issue #6544 by:
Checklist
npm testpassesDescription of change
Sort函数的处理会对domain的重新赋值，会导致 domain 的间隔隐藏值的展示（当宽度很小时，domain 还是会适当省略）（单测gammaRandomLineSortXQuantitative.svg变化的原因）ordinal的理解是：若数据是折线图这种数据连续性强的图需要设置 false，ordinal 是否要对数据的连续性前后关系进行重新排序，true 只对 domain 进行重新排序，false 同时对 domain 和数据的连续性前后关系进行重新排序。