Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zy/5 dashboard migrate indi app #234

Merged
merged 43 commits into from
Mar 11, 2025
Merged

Zy/5 dashboard migrate indi app #234

merged 43 commits into from
Mar 11, 2025

Conversation

zheyxu
Copy link
Collaborator

@zheyxu zheyxu commented Mar 6, 2025

Pull Request Details

What issue does this PR address

Checklist

Complete the check-list below to ensure your branch is ready for PR.

Flutter Style Guide: https://survivor.togaware.com/gnulinux/flutter-style.html

  • Screenshots included in linked issue
  • Changes adhere to the style and coding guideline
  • No confidential information
  • No duplicated content
  • No lint check errors related to your changes (make prep or flutter analyze lib)
  • Pre-exisiting lint errors noted: [HERE]
  • Integration test make qtest.tmp screenshot included in issue
  • Tested on device:
    • Linux
    • MacOS
    • Windows
    • Android
    • iOS
    • Web
  • Added software engineer reviewer
  • Approved by one software engineer reviewer
  • Approved by team leader

Finalising

Once PR discussion is complete and reviewers have approved:

  • Merge dev into the branch
  • Resolve any conflicts
  • Add one line summary into CHANGELOG.md
  • Bump appropriate version number in pubspec.yaml
  • Push to git repository and review
  • Merge PR into dev

@zheyxu zheyxu requested review from gjwgit, junhaow1 and atangster March 6, 2025 01:26
@zheyxu zheyxu linked an issue Mar 6, 2025 that may be closed by this pull request
3 tasks
@zheyxu
Copy link
Collaborator Author

zheyxu commented Mar 6, 2025

@gjwgit The audioplayers packages raise the failure of integration test in Linux build app.

The error message indicates that the Linux build is failing because the required GStreamer package (“gstreamer-1.0”) is not found. This dependency comes from the audioplayers_linux plugin (or another plugin that relies on GStreamer).

To fix this issue, you need to install the necessary GStreamer development packages on your Linux system. 

The vm test machine should be updated.

Copy link
Collaborator

@atangster atangster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall look good, a few things to consider/fix

@junhaow1
Copy link
Collaborator

@zheyxu conflict here

@junhaow1
Copy link
Collaborator

once Ashley's comments have been resolved I will review this @zheyxu

@zheyxu
Copy link
Collaborator Author

zheyxu commented Mar 11, 2025

Hi @junhaow1 @atangster, please check the updated pr.

@gjwgit gjwgit requested a review from atangster March 11, 2025 23:53
@zheyxu zheyxu merged commit 594308f into dev Mar 11, 2025
6 checks passed
@zheyxu zheyxu deleted the zy/5_dashboard_migrate_indi_app branch March 11, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DASHBOARD: Migrate Indi app dashboard to HealthPod
4 participants