Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ash/236 refactor file service #238

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Ash/236 refactor file service #238

wants to merge 8 commits into from

Conversation

atangster
Copy link
Collaborator

@atangster atangster commented Mar 6, 2025 •
edited
Loading

Pull Request Details

Link to associated issue: #236

Merge into #235

Checklist

Complete the check-list below to ensure your branch is ready for PR.

Flutter Style Guide: https://survivor.togaware.com/gnulinux/flutter-style.html

  • Screenshots included in linked issue
  • Changes adhere to the team style and coding guideline
  • No confidential information
  • No duplicated content
  • No lint check errors related to your changes (make prep or flutter analyze lib)
  • Tested on at least one device
    • Windows
  • Added 2 reviewers (or 1 for private repositories then they add another)

@atangster atangster changed the base branch from dev to atangster/173_refactor_file_browser March 6, 2025 14:14
@atangster atangster requested review from junhaow1 and zheyxu March 6, 2025 14:28
@atangster atangster changed the title Ash/236 refactor service Ash/236 refactor file service Mar 6, 2025
@atangster
Copy link
Collaborator Author

Blocked until #235 fixed

@atangster atangster marked this pull request as draft March 11, 2025 06:50
@zheyxu
Copy link
Collaborator

zheyxu commented Mar 12, 2025

When the pr is changed from draft to open, then it can be reviewed.

@atangster
Copy link
Collaborator Author

@zheyxu @junhaow1 ready for review

@atangster atangster marked this pull request as ready for review March 12, 2025 15:13
zheyxu
zheyxu requested changes Mar 13, 2025
View reviewed changes
Copy link
Collaborator

@zheyxu zheyxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To pass the tests, unused file should be removed.
⚠ unused file: /home/runner/work/healthpod/healthpod/lib/features/vaccination/exporter.dart
⚠ unused file: /home/runner/work/healthpod/healthpod/lib/features/vaccination/importer.dart

Base automatically changed from atangster/173_refactor_file_browser to dev March 13, 2025 02:28
@atangster
remove unused file
d84f28a 
removed unused file
@atangster atangster force-pushed the atangster/236_refactor_service branch from bf160ef to d84f28a Compare March 13, 2025 02:42
@atangster atangster requested a review from zheyxu March 13, 2025 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junhaow1 junhaow1 junhaow1 approved these changes

@zheyxu zheyxu zheyxu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atangster @zheyxu @junhaow1