Disable ORM access from Tasks, DAG processing and Triggers #47320
+95
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
requested review from
jscheffl,
eladkal,
o-nikolas,
ephraimbuddy and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:API
ashb
force-pushed
the
disable-db-access-tasks
branch
from
18faa85 to
eb14f67
Compare
ashb
changed the title
ashb
force-pushed
the
disable-db-access-tasks
branch
from
eb14f67 to
2a77c31
Compare
ashb
commented
Mar 4, 2025
| @@ -101,7 +101,7 @@ | |||
| """ | |||
|
|
|||
| engine: Engine | |||
| Session: Callable[..., SASession] | |||
| Session: sessionmaker | |||
There was a problem hiding this comment.
This change is not needed,
Suggested change
| Session: sessionmaker | |
| Session: Callable[..., SASession] |
vincbeck
approved these changes
Mar 4, 2025
jedcunningham
approved these changes
Mar 4, 2025
All of these use the Workload supervisor from the TaskSDK and the main paths (XCom, Variables and Secrets) have all been ported to use the Execution API, so it's about time we disabled DB access.
ashb
force-pushed
the
disable-db-access-tasks
branch
from
e55d781 to
1176f81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's about time we delivered on one of the key points of AIP-72: DB isolation from workers.
(To be honest, it's probably past time, but now is the second best time)
All of these use the Workload supervisor from the TaskSDK and the main paths
XCom, Variables and Secrets) have all been ported to use the Execution API,
so it's about time we disabled DB access.
Note: this will almost certainly break a few things, like Skip mixin based tasks in particular - that is WIP in 46584
Also closes #47232 as that was failing if configure_orm was never called.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.