fix: mark (Large)ListView as nested and support in equal data type #6995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rluvaton
commented
Jan 19, 2025
There was a problem hiding this comment.
I don't we should use wildcard pattern in this file for matching data type
There was a problem hiding this comment.
Given how rarely this enumeration changes, I'm inclined to optimise for legibility and continue to use wildcard matches
tustvold
approved these changes
Jan 19, 2025
totoroyyb
pushed a commit
to totoroyyb/arrow-rs
that referenced
this pull request
Jan 20, 2025
alamb
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
ListViewandLargeListVieware nested and should have correct equal data type implWhat changes are included in this PR?
is_nestedin thedatatype.rsfile to returntrueforListViewandLargeListViewequals_datatypein thedatatype.rsfile to skip checking file field name and metadata forListViewandLargeListViewcontainsin thedatatype.rsfile to use the same logic forListViewandLargeListViewthat is used for theListdata typeAre there any user-facing changes?
Kind of.
and this is considered breaking change if looking at it from behavior perspective, but I don't think it should be marked as one