Skip to content

Commit

Permalink
GH-44974: [Dev] Fix minor issue handling (#44975)
Browse files Browse the repository at this point in the history
### Rationale for this change

The current implementation works for `GH-XXX` PRs but doesn't work for `MINOR` PRs.

### What changes are included in this PR?

Add a missing `issue.kind` check.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.

* GitHub Issue: #44974

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
  • Loading branch information
pitrou authored Dec 9, 2024
1 parent e0f8c5e commit f1b293d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/dev_pr/link.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ module.exports = async ({github, context}) => {
const pullRequestNumber = context.payload.number;
const title = context.payload.pull_request.title;
const issue = helpers.detectIssue(title);
if (issue){
if (issue && issue.kind === "github") {
await commentGitHubURL(github, context, pullRequestNumber, issue.id);
}
};

0 comments on commit f1b293d

Please sign in to comment.