WIP: Updated cordova-common and cordova-lib for the new framework link attribute. #584
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
This PR depends on 2 other PRs:
apache/cordova-common#179
apache/cordova-lib#898
This PR is to update cordova-cli for the new link attribute being introduced in cordova-common.
This PR is directly related to apache/cordova-ios#1266
This PR provides support for reading the link attribute from framework tags.
The cordova-ios PR updates the iOS platform to use the new link attribute when adding frameworks.
cordova-docs pr: apache/cordova-docs#1267
Description
Updated cordova-common to apache/cordova-common#179.
Update cordova-lib to apache/cordova-lib#898.
Testing
I've ran npm test.
Tested various combinations of framework tag's embed and link attributes by installing a plugin using these attributes. I would observe how the XCFramework is added to the the XCode project with the following focuses:
-Is the XCFramework embedded (or not embedded) in Build Phrases?
-Is the XCFramework linked (or not linked) in Build Phrases?
-Is the XCFramework set to "Embed and Sign" in General?
I have ran my company's app using these changes.
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)