Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update node engine requirement >= 16 #909

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

erisu
Copy link
Member

@erisu erisu commented Jan 10, 2023

Platforms affected

n/a

Motivation and Context

  • prepare for next major node requirement
  • node 14 support EOL coming in April

Description

Set node engine requirement to >=16

Testing

n/a

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu added this to the 12.0.0 milestone Jan 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2023

Codecov Report

Merging #909 (8e652c6) into master (6aa4c09) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #909   +/-   ##
=======================================
  Coverage   88.27%   88.27%           
=======================================
  Files          46       46           
  Lines        2123     2123           
=======================================
  Hits         1874     1874           
  Misses        249      249           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@erisu erisu merged commit 09e56c1 into apache:master Jan 10, 2023
@erisu erisu deleted the feat/update-node-requirement branch January 10, 2023 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants