Fix all Auto-Application Errors #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olabusayoT
requested review from
mbeckerle,
stevedlawrence and
jadams-tresys
- using scalafix - used `scalafixAll dependency:[email protected]:scala-rewrites:0.1.5` - fixed some false positives DAFFODIL-2152
olabusayoT
force-pushed
the
daf-2152-fix-all-auto-application
branch
from
8074e1f to
03f9c3e
Compare
jadams-tresys
approved these changes
Feb 12, 2025
| @@ -101,7 +101,7 @@ class DFDLDefineVariable private (node: Node, doc: SchemaDocument) | |||
| this.SDE("Variables must have primitive type. Type was '%s'.", typeQName.toPrettyString) | |||
| ) | |||
|
|
|||
| final def createVariableInstance = variableRuntimeData.createVariableInstance | |||
| final def createVariableInstance = variableRuntimeData.createVariableInstance() | |||
There was a problem hiding this comment.
I was surprised to see that this didn't have test coverage, but sure enough this doesn't get used anywhere and this line can be completely removed. Don't know if we want to do it in this pull request or not though.
There was a problem hiding this comment.
I think somewhere else is was commented that we should avoid making changes that aren't related to the 2.13 conversion. Various cleanups and removing dead code probably want to wait until everything is done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scalafixAll dependency:[email protected]:scala-rewrites:0.1.5DAFFODIL-2152