Minor: make unsupported nanosecond part a real (not internal) error
#13733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Dec 11, 2024
| @@ -225,7 +225,7 @@ SELECT EXTRACT(microsecond FROM timestamp '2020-09-08T12:00:12.12345678+00:00') | |||
| ---- | |||
| 12123456 | |||
|
|
|||
| query error DataFusion error: Internal error: unit Nanosecond not supported | |||
| query error DataFusion error: This feature is not implemented: unit Nanosecond not supported | |||
There was a problem hiding this comment.
This demonstrates the behavior change -- it is not an internal error anymore
findepi
approved these changes
Dec 11, 2024
xudong963
approved these changes
Dec 12, 2024
I double checked @findepi and indeed this is the nanosecond part, so I improved the message in 95d0dd5 Thank you @xudong963 for the review 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
I noticed this while working on #13732
Extracting nanoseconds from a timestamp is not supported, but currently that is marked as in internal error. Let's make it the proper code (not supported)
What changes are included in this PR?
Changes:
Are these changes tested?
Yes, this change is covered by tests (see updates)
Are there any user-facing changes?
Clearer error message