[minor] add missing slt tests for count(partitioned,aggregated, aggregated cube) #13790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
Dec 15, 2024
There was a problem hiding this comment.
Thank you @buraksenn 🙏
You mention a TODO in the PR description. Should we also remove the TPDP?
alamb
approved these changes
Dec 15, 2024
Thanks @alamb. I've already deleted them they are in the slt file actually |
alamb
reviewed
Dec 15, 2024
| @@ -2179,11 +2179,62 @@ SELECT COUNT(c1), COUNT(c2) FROM test | |||
| ---- | |||
| 4 4 | |||
|
|
|||
| # TODO: count_partitioned | |||
|
LGTM, double-checked with postgre |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
I saw TODO's in the codebase that these did not have any slt tests
What changes are included in this PR?
Several slt test cases for count(partitioned,aggregated, aggregated cube)
Are these changes tested?
They are only slt tests
Are there any user-facing changes?
No