fix : use get_record_batch_memory_size for calculating RecordBatch memory size in topK
#13906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getChan
commented
Dec 26, 2024
|
|
||
| // when insert record batch entry | ||
| record_batch_store.insert(record_batch_entry); | ||
| assert_eq!(record_batch_store.batches_size, 60); |
There was a problem hiding this comment.
Before, it was 252.
alamb
changed the title
get_record_batch_memory_size for calculating RecordBatch memory size in topK
alamb
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #13430.
Rationale for this change
In Top K, the RecordBatch size is overestimated. Fix it by using
get_record_batch_memory_size.What changes are included in this PR?
Are these changes tested?
Unit tested for a narrow range.
Are there any user-facing changes?
No