fix: series cursor setting not working on label #15703
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Ovilia
requested changes
Sep 10, 2021
src/chart/bar/BarView.ts
Outdated
| @@ -996,6 +996,8 @@ function updateStyle( | |||
| ); | |||
| } | |||
|
|
|||
| cursorStyle && label.attr('cursor', cursorStyle); | |||
There was a problem hiding this comment.
Many other series may have similar problems. Please consider setting cursor information to labels in LabelManager. You may refer to updateBlend for reference.
There was a problem hiding this comment.
Now setting cursor in processLabelsOverall of LabelManager 😂
echarts-bot
bot
added
PR: revision needed
PR: awaiting review
and removed
PR: awaiting review
PR: revision needed
labels
kongmoumou
changed the title
kongmoumou
force-pushed
the
fix-bar-cursor
branch
from
101cbd5 to
4552592
Compare
|
I have found the cursor setting also not working on line series and custom series when I wanted to only have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fixed issues
#15631
Details
Before: What was the problem?
see #15631
After: How is it fixed in this PR?
sync
cursoroption to labelMisc
Related test cases or examples to use the new APIs
NA.
Others
Merging options
Other information