Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BP-2.0][FLINK-37350][table-planner] Fix memory leak caused by skewed join optimization strategy #26200

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

noorall
Copy link
Contributor

@noorall noorall commented Feb 24, 2025

What is the purpose of the change

When the AdaptiveBroadcastJoinOptimizationStrategy is in effect, it leads to the statistics in the AdaptiveSkewedJoinOptimizationStrategy to not be released properly, which causes memory leaks. This PR is intended to fix the issue.

Brief change log

Fix memory leak caused by skewed join optimization strategy.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 24, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@noorall
Copy link
Contributor Author

noorall commented Feb 25, 2025

@flinkbot run azure

@noorall
Copy link
Contributor Author

noorall commented Feb 25, 2025

After revert the commit 3829bb5 , connect CI test pass in my Github Action: https://github.com/noorall/flink/actions/runs/13512239439

Copy link
Contributor

@JunRuiLee JunRuiLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @noorall , LGTM

@JunRuiLee JunRuiLee merged commit 44c8462 into apache:release-2.0 Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants