[FLINK-36585][connector/common] SplitFetcherManager.close() should not chain runnables to the element queue future in a tight loop #26205
+97
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t chain runnables to the element queue future in a tight loop. This is a re-commit of the patch after fixing the accidentally changed timeout unit of the SplitFetcherManager close timeout.
|
@PatrickRen Can you take another look? cc @snuyanzin |
davidradl
reviewed
Feb 26, 2025
| e); | ||
| break; | ||
| } | ||
| timeElapsed = System.currentTimeMillis() - startTime; |
There was a problem hiding this comment.
Could we put out a log if we have timed out with elements still on the queue, or would the await termination LOG.warn( catch this?
There was a problem hiding this comment.
Exactly, the await termination LOG.warn() would catch it.
PatrickRen
approved these changes
Feb 28, 2025
becketqin
added a commit
that referenced
this pull request
Feb 28, 2025
…timeout unit of the SplitFetcherManager close timeout. And improve the test stability. (#26205)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This is a re-commit of the patch ( #25569 ) after fixing the accidentally changed timeout unit of the SplitFetcherManager close timeout.
Brief change log
Changes in the Original Fix:
This patch fixes an issue introduced in #25130. In SplitFetcherManager.close(), the element queue draining thread was chaining the runnables to the element queue availability future in a tight loop. This causes problem (e.g. OOM, high CPU util) when the fetcher threads do not shutdown quickly.
This patch changes the tight async loop to a blocking loop.
Changes in the followup patch fixes the accidentally changed timeout unit of the SplitFetcherManager close timeout.
Verifying this change
Unit tests have been added.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation