Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] refactoring methods replaceCryPlaceholder and replaceSmilingPlace #2832

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

[refactor] refactoring methods replaceCryPlaceholder and replaceSmilingPlace #2832

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
97951c9
Issue 2056 refactoring methods replaceCryPlaceholder and replaceSmili…
hasimmollah Nov 23, 2024
390c66c
Issue 2056 refactoring methods replaceCryPlaceholder and replaceSmili…
hasimmollah Nov 23, 2024
0e681ab
Merge branch 'master' into feature-issue-2056
zuobiao-zhou Nov 24, 2024
50dafa1
Issue 2056 adding test cases
hasimmollah Nov 24, 2024
9777197
Merge branch 'master' of github.com:apache/hertzbeat into feature-iss…
hasimmollah Nov 24, 2024
037c4af
Merge branch 'feature-issue-2056' of github.com:hasimmollah/hertzbeat…
hasimmollah Nov 24, 2024
3360527
Issue 2056 formatting test class
hasimmollah Nov 24, 2024
78e8de9
Merge branch 'master' into feature-issue-2056
Aias00 Nov 27, 2024
5acfd71
Merge branch 'master' into feature-issue-2056
Calvin979 Nov 27, 2024
65beeb2
Merge branch 'master' into feature-issue-2056
tomsun28 Nov 30, 2024
9aaac23
Merge branch 'master' into feature-issue-2056
tomsun28 Dec 1, 2024
2690b28
Merge branch 'master' into feature-issue-2056
Aias00 Dec 5, 2024
682ee42
Merge branch 'master' into feature-issue-2056
Aias00 Dec 5, 2024
8b5f008
Merge branch 'master' into feature-issue-2056
hasimmollah Dec 9, 2024
e67097f
Merge branch 'master' into feature-issue-2056
Aias00 Dec 14, 2024
c7ce5d6
Merge branch 'master' into feature-issue-2056
Aias00 Dec 16, 2024
5c6a9e0
Merge branch 'master' into feature-issue-2056
hasimmollah Dec 23, 2024
08c9784
Merge branch 'master' into feature-issue-2056
Aias00 Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Issue 2056 formatting test class
  • Loading branch information
@hasimmollah
hasimmollah committed Nov 24, 2024
commit 33605274eeec6b09db919cd0d99ea5ddddd7cfd2
4 changes: 3 additions & 1 deletion ...at-collector-basic/src/test/java/org/apache/hertzbeat/collector/util/CollectUtilTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,9 @@ static Stream<Arguments> testParamsForShouldVerifyReplaceCryPlaceholder() {

@ParameterizedTest
@MethodSource("testParamsForShouldVerifyReplaceCryPlaceholder")
void shouldVerifyReplaceCryPlaceholder(JsonObject jsonObject, Map<String, Configmap> configmap, JsonObject jsonObjectTarget) throws JsonProcessingException {
void shouldVerifyReplaceCryPlaceholder(JsonObject jsonObject,
Map<String, Configmap> configmap,
JsonObject jsonObjectTarget) throws JsonProcessingException {

JsonElement res1 = CollectUtil.replaceCryPlaceholder(jsonObject, configmap);
assertEquals(JSON_MAPPER.readTree(jsonObjectTarget.toString()), JSON_MAPPER.readTree(res1.toString()));
Expand Down
Loading