Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] update alarm inhibit rule and alarm ui #2957

Merged
merged 25 commits into from
Jan 8, 2025
Merged

Conversation

tomsun28
Copy link
Contributor

@tomsun28 tomsun28 commented Jan 6, 2025

What's changed?

  • update alarm inhibit rule and alarm ui
  • fix monitors alerts import export bug

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 2935 files.

Valid Invalid Ignored Fixed
1527 1 1407 0
Click to see the invalid file list
  • hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/reduce/AlarmGroupReduceTest.java
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

@@ -0,0 +1,86 @@
package org.apache.hertzbeat.alert.reduce;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
package org.apache.hertzbeat.alert.reduce;
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.hertzbeat.alert.reduce;

@tomsun28 tomsun28 added this to the 1.7.0 milestone Jan 7, 2025
@github-actions github-actions bot added the doc Improvements or additions to documentation label Jan 7, 2025
@github-actions github-actions bot added the home label Jan 7, 2025
@tomsun28 tomsun28 requested a review from zqr10159 January 7, 2025 11:56
@zqr10159 zqr10159 merged commit f7676ac into master Jan 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation docker docker-compose home script webapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants