Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the search functionality issue. #2970

Merged
merged 7 commits into from
Jan 10, 2025
Merged

Fix the search functionality issue. #2970

merged 7 commits into from
Jan 10, 2025

Conversation

yunfan24
Copy link
Contributor

@yunfan24 yunfan24 commented Jan 8, 2025 •
edited
Loading

What's changed?

Issue

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@github-actions github-actions bot added the webapp label Jan 8, 2025
tomsun28
tomsun28 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@tomsun28 tomsun28 added this to the 1.7.0 milestone Jan 10, 2025
@tomsun28 tomsun28 linked an issue Jan 10, 2025 that may be closed by this pull request
[BUG] Questions about the search function #2956
Closed
1 task
@tomsun28 tomsun28 added the good first pull request Good for newcomers label Jan 10, 2025
@tomsun28 tomsun28 merged commit e905f36 into apache:master Jan 10, 2025
3 checks passed
@yunfan24 yunfan24 deleted the fix-search branch January 11, 2025 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
bugfix good first pull request Good for newcomers webapp
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

[BUG] Questions about the search function
3 participants
@yunfan24 @tomsun28 @Aias00