mod_ssl: Don't reject expired client certs with optional_no_ca. #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SSLVerifyClient optional_no_ca setting has been broken since it was introduced in that expired certificates result in the request being rejected, which is contrary to the documentation and how the setting is supposed to behave. To fix this, add X509_V_ERR_CRL_HAS_EXPIRED to the list of error exceptions that allow ssl_callback_SSLVerify in ssl_engine_kernel.c and ssl_io_filter_handshake in ssl_engine_io.c to accept the client certificate anyways. Submitted by: Naveen Albert <[email protected]> PR: 60028 PR: 60186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SSLVerifyClient optional_no_ca setting has been broken since it was introduced in that expired certificates result in the request being rejected, which is contrary to the documentation and how the setting is supposed to behave. To fix this, add X509_V_ERR_CRL_HAS_EXPIRED to the list of error exceptions that allow ssl_callback_SSLVerify in ssl_engine_kernel.c and ssl_io_filter_handshake in ssl_engine_io.c to accept the client certificate anyways.
PR: 60028
PR: 60186