Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-8304][CH]Optimize get_json_object nested functions call #8305

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

KevinyhZou
Copy link
Contributor

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #8304)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@github-actions github-actions bot added CORE works for Gluten Core CLICKHOUSE labels Dec 23, 2024
Copy link

#8304

Copy link

Run Gluten Clickhouse CI on x86

@KevinyhZou KevinyhZou marked this pull request as draft December 23, 2024 04:24
Copy link

Run Gluten Clickhouse CI on x86

@PHILO-HE
Copy link
Contributor

@KevinyhZou, I think this optimization can also be applied to Velox backend. Can you move this rule to a common place? BTW, there seems no need to add a new config. Maybe, just make the optimization always enabled. Thanks!

@KevinyhZou KevinyhZou changed the title [GLUTEN-8304][CH]Optmize get_json_object nested functions call [GLUTEN-8304][CH]Optimize get_json_object nested functions call Dec 23, 2024
@PHILO-HE
Copy link
Contributor

Hi @WangGuangxin, I note there is a config called spark.sql.collapseGetJsonObject.enabled according to this link. Is that optimization implemented by your team similar to this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLICKHOUSE CORE works for Gluten Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CH] Optimize get_json_object nested function calls
2 participants