Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-8313][VL] Enable json_array_length #8314

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

WangGuangxin
Copy link
Contributor

What changes were proposed in this pull request?

Enable json_array_length

(Fixes: #8313)

How was this patch tested?

UT

@github-actions github-actions bot added the VELOX label Dec 24, 2024
Copy link

#8313

@WangGuangxin
Copy link
Contributor Author

pending facebookincubator/velox#11946

@PHILO-HE
Copy link
Contributor

PHILO-HE commented Dec 24, 2024

@WangGuangxin, could you enable the functionality in this pr to see CI feedback in advance?
It requires changing the Velox branch to your own one with that velox patch applied.
https://github.com/apache/incubator-gluten/blob/main/ep/build-velox/src/get_velox.sh#L20

@github-actions github-actions bot added the BUILD label Dec 24, 2024
VELOX_REPO=https://github.com/oap-project/velox.git
VELOX_BRANCH=2024_12_23
VELOX_REPO=https://github.com/WangGuangxin/velox.git
VELOX_BRANCH=feat_json_array_length
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WangGuangxin, you need create a branch based on 2024_12_23 branch of oap-project, then apply your upstream velox patch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VL] Enable json_array_length
2 participants